-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geometry validation methods #14
Comments
I am just copying over a comment from code I am cleaning up that connects to this: What to do for corner cases (nan point, etc)? |
I imagine this working on several levels, and one would ascend the tree from the bottom up, from point to feature collection. If empty geometries are deemed valid, ok - if not, then we could flag invalid and remove them.
For all geometries, antimeridian cutting is a viable method. The only issue is passing per-point attributes through for plotting - which will probably require a reimplementation in GeoMakie. Alternatively, we could have internal functions here which return a list of the indices of altered/added vertices (perhaps when called with a Feature collections - I guess validity checks are just https://learn.microsoft.com/en-us/sql/relational-databases/spatial/linestring?view=sql-server-ver16 is a nice link I thought |
We need some functions like Rs
sf_make_valid
to validate geometry correctness. R is just using GEOS for this.Currently we are in a wild-west situation where anything reads, writes and plots and will just randomly fail when it hits methods where validity matters.
The text was updated successfully, but these errors were encountered: