Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

force2d, forcez, forcem, forcezm #109

Open
asinghvi17 opened this issue Apr 16, 2024 · 4 comments
Open

force2d, forcez, forcem, forcezm #109

asinghvi17 opened this issue Apr 16, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@asinghvi17
Copy link
Member

Shapely has these and it seems pretty useful when dealing with nightmare datasets.

forcez(geoms; default = 0)
forcezm(geoms; defaultz = 1, defaultm = 0)

or something
@asinghvi17 asinghvi17 added enhancement New feature or request good first issue Good for newcomers labels Apr 16, 2024
@rafaqz
Copy link
Member

rafaqz commented Apr 16, 2024

These only are a few lines with apply.

@rafaqz
Copy link
Member

rafaqz commented Apr 17, 2024

I think I like forcexy, forcexyz, forcexym, forcexyzm better as its clearer what you get back. Like does the result of forcez have m in it if it was already there?

I have a PR anyway

@asinghvi17
Copy link
Member Author

Yeah that is a good point - being explicit about it makes sense.

@asinghvi17
Copy link
Member Author

Forcexy and forcexyz are implemented in #239

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rafaqz @asinghvi17