Skip to content

Commit

Permalink
Refactor name to `MonotoneChainMethod
Browse files Browse the repository at this point in the history
Co-authored-by: Daniel VandenHeuvel <95613936+DanielVandH@users.noreply.github.com>
  • Loading branch information
asinghvi17 and DanielVandH authored Jul 17, 2024
1 parent 0402877 commit bb4a266
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/methods/convex_hull.jl
Original file line number Diff line number Diff line change
Expand Up @@ -61,15 +61,15 @@ This is a pure Julia algorithm which provides an optimal Delaunay triangulation.
See also [`convex_hull`](@ref)
"""
struct DelaunayTriangulationMethod end
struct MonotoneChainMethod end

# , [`DelaunayTriangulationMethod`](@ref), [`EarCutMethod`](@ref).
# , [`MonotoneChainMethod`](@ref), [`EarCutMethod`](@ref).
# GrahamScanMethod, etc. can be implemented in GO as well, if someone wants to...

convex_hull(geometries) = convex_hull(DelaunayTriangulationMethod(), geometries)
convex_hull(geometries) = convex_hull(MonotoneChainMethod(), geometries)

# TODO: have this respect the CRS by pulling it out of `geometries`.
function convex_hull(::DelaunayTriangulationMethod, geometries)
function convex_hull(::MonotoneChainMethod, geometries)
# Extract all points as tuples. We have to collect and allocate
# here, because DelaunayTriangulation only accepts vectors of
# point-like geoms.
Expand Down

0 comments on commit bb4a266

Please sign in to comment.