Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Requires.jl with Pkg extensions for collect_results? #417

Open
Datseris opened this issue Jun 7, 2024 · 2 comments
Open

Replace Requires.jl with Pkg extensions for collect_results? #417

Datseris opened this issue Jun 7, 2024 · 2 comments
Labels
running-listing Functionality for running and listing simulation runs

Comments

@Datseris
Copy link
Member

Datseris commented Jun 7, 2024

At the moment the collect_results functionality is done using Requires.jl to conditionally load code on using DataFrames.jl.

Julia 1.10 and later versions have the Package extensions system which is more robust and natively supported. Doing the switch from Requires.jl to Pkg is honestly trivially easy, here is an example of doing it for e.g., TimeseriesSurrogates.jl for a plotting conditional dependency:

https://github.com/JuliaDynamics/TimeseriesSurrogates.jl/blob/main/src/plotting/surrogate_plot.jl and https://github.com/JuliaDynamics/TimeseriesSurrogates.jl/blob/main/ext/TimeseriesSurrogatesVisualizations.jl and https://github.com/JuliaDynamics/TimeseriesSurrogates.jl/blob/main/Project.toml#L27

Should we do the switch? It would require later versions of DrWatson to raise the Julia dependency from 1.0 to 1.10. I don't know what the impact of this is for the average DrWatson user, as I've always used latest stable version... How many honestly use 1.0 only, and more importantly, why?

@Datseris Datseris added the running-listing Functionality for running and listing simulation runs label Jun 7, 2024
@ReubenJ
Copy link

ReubenJ commented Jan 30, 2025

Just ran into the same question and came across this solution for supporting both Requires and Pkg extensions: SciML/DiffEqBase.jl@c2de920#diff-de4c4ba0a280ecb9ba500e64be262686e3f8efdd99b60152eec26cc1263afbb1

in case you'd like to use extensions without upping the lower bound on the Julia version.

@ReubenJ
Copy link

ReubenJ commented Jan 30, 2025

I see the plan is to only support >1.9 as of #425, so maybe this isn't useful in the end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
running-listing Functionality for running and listing simulation runs
Projects
None yet
Development

No branches or pull requests

2 participants