Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SARIMAX #7

Open
detrin opened this issue Aug 5, 2023 · 4 comments
Open

SARIMAX #7

detrin opened this issue Aug 5, 2023 · 4 comments

Comments

@detrin
Copy link

detrin commented Aug 5, 2023

Hello,

would you be open on adding X into SARIMA model to get also SARIMAX? The only option as of now is statsmodels in python. I don't count using R as an option. https://www.statsmodels.org/stable/generated/statsmodels.tsa.statespace.sarimax.SARIMAX.html
Which is alright, but it is terribly slow, because the whole implementation is just in python. I was thinking about writing SARIMAX from scratch in rust language, but that would be indeed nontrivial amount of work. I found your package and it looks very well, except missing the input for exogenous variables.

image
Source: https://towardsdatascience.com/time-series-forecasting-with-arima-sarima-and-sarimax-ee61099e78f6

Would you be open to this feature?

@detrin
Copy link
Author

detrin commented Aug 5, 2023

Plus there is probably no seasonal component, I am not sure about that.

@Datseris
Copy link
Member

Datseris commented Aug 6, 2023

if you can put in a PR together that is non-breaking with respect to current api that's totally fine. If its breaking just increment version in Project.toml

@detrin
Copy link
Author

detrin commented Aug 6, 2023

if you can put in a PR together that is non-breaking with respect to current api that's totally fine. If its breaking just increment version in Project.toml

I will consider this option, thanks for the response.

@gvdr
Copy link

gvdr commented Oct 2, 2023

if you can put in a PR together that is non-breaking with respect to current api that's totally fine. If its breaking just increment version in Project.toml

I will consider this option, thanks for the response.

For the time being, you can take a look at https://github.com/Baffelan/Stranbo.jl

Would be keen to benchmark it against the python version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants