-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update faq.md #414
Update faq.md #414
Conversation
Remake of the "How do I subset a Cube? " section in order to incorporate information of various ways of selection, including selecting a variable based on the values of another variable with which it shares a dimension.
docs/src/UserGuide/faq.md
Outdated
````@ansi howdoi | ||
y = YAXArray(axes, reshape(1:3600, (10, 10, 36))) | ||
```` | ||
````@ansi howdoi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all the second ansi blocks are not necessary. That is the output from the previous one, after execution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I separate them in order for the user to easily copy the input and paste and run it in the console in a quick way. If both blocks were the same, it would be not so ease. The button on the up-right corner of the block, would copy both the input and the output.
Perhaps the style of the blocks should be different for the input than for the output?.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How I can achieve this behavior? Could you suggest me a link to a documentation page for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just seen how to do it. I do not have to explicitly add the output. It is automatically generated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #414 +/- ##
==========================================
+ Coverage 68.15% 68.30% +0.14%
==========================================
Files 12 12
Lines 1771 1773 +2
==========================================
+ Hits 1207 1211 +4
+ Misses 564 562 -2 ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 10094752696Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9907774908Details
💛 - Coveralls |
Ok @coveralls , I will fix it. |
Eliminated explicit output blocks. Added information about subsetting when the data is not loaded into memory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can incorporate the suggested changes (if you agree) by clicking the button commit suggestion. Thanks for the PR.
Co-authored-by: Lazaro Alonso <lazarus.alon@gmail.com>
Co-authored-by: Lazaro Alonso <lazarus.alon@gmail.com>
Co-authored-by: Lazaro Alonso <lazarus.alon@gmail.com>
Co-authored-by: Lazaro Alonso <lazarus.alon@gmail.com>
Co-authored-by: Lazaro Alonso <lazarus.alon@gmail.com>
Take into account that a Cube is no more than a YAXArray. So, the explicit section about Cubes has been deleted.
I have deleted a comment in the code exaple because I do not understand it.
Remake of the "How do I subset a Cube? " section in order to incorporate information of various ways of selection, including selecting a variable based on the values of another variable with which it shares a dimension.