Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Make Metadata a type parameter of YAXArray" #371

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Revert "Make Metadata a type parameter of YAXArray" #371

merged 1 commit into from
Feb 22, 2024

Conversation

lazarusA
Copy link
Collaborator

Reverts #370

Not only breaks yax inference but also DD ones.

@lazarusA lazarusA merged commit ddfb9a8 into master Feb 22, 2024
3 of 9 checks passed
@lazarusA
Copy link
Collaborator Author

@felixcremer could you test the example given in rafaqz/DimensionalData.jl#641 and check that it works when you have yax-patch and DD main, please?

@github-actions GitHub Actions
Copy link
Contributor

Benchmark result

Judge result

Benchmark Report for /home/runner/work/YAXArrays.jl/YAXArrays.jl

Job Properties

  • Time of benchmarks:
    • Target: 22 Feb 2024 - 15:35
    • Baseline: 22 Feb 2024 - 15:35
  • Package commits:
    • Target: 1653bf
    • Baseline: ddfb9a
  • Julia commits:
    • Target: 7790d6
    • Baseline: 7790d6
  • Julia command flags:
    • Target: None
    • Baseline: None
  • Environment variables:
    • Target: None
    • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["mapslices", "small"] 0.03 (5%) ✅ 0.31 (1%) ✅

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["mapslices"]

Julia versioninfo

Target

Julia Version 1.10.1
Commit 7790d6f0641 (2024-02-13 20:41 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.4 LTS
  uname: Linux 6.2.0-1019-azure #19~22.04.1-Ubuntu SMP Wed Jan 10 22:57:03 UTC 2024 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  2445 MHz        799 s          0 s         97 s       2754 s          0 s
       #2  3242 MHz        938 s          0 s         99 s       2614 s          0 s
       #3  2445 MHz        619 s          0 s        121 s       2885 s          0 s
       #4  2596 MHz       1073 s          0 s        104 s       2475 s          0 s
  Memory: 15.606903076171875 GB (13761.60546875 MB free)
  Uptime: 368.65 sec
  Load Avg:  1.7  0.99  0.41
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Baseline

Julia Version 1.10.1
Commit 7790d6f0641 (2024-02-13 20:41 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.4 LTS
  uname: Linux 6.2.0-1019-azure #19~22.04.1-Ubuntu SMP Wed Jan 10 22:57:03 UTC 2024 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  3249 MHz        846 s          0 s         99 s       2908 s          0 s
       #2  3242 MHz        993 s          0 s        103 s       2758 s          0 s
       #3  2445 MHz        706 s          0 s        124 s       2999 s          0 s
       #4  2445 MHz       1085 s          0 s        105 s       2666 s          0 s
  Memory: 15.606903076171875 GB (13800.34375 MB free)
  Uptime: 389.05 sec
  Load Avg:  1.5  0.99  0.42
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Target result

Benchmark Report for /home/runner/work/YAXArrays.jl/YAXArrays.jl

Job Properties

  • Time of benchmark: 22 Feb 2024 - 15:35
  • Package commit: 1653bf
  • Julia commit: 7790d6
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["mapslices", "small"] 243.901 ms (5%) 168.775 ms 330.27 MiB (1%) 91076

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["mapslices"]

Julia versioninfo

Julia Version 1.10.1
Commit 7790d6f0641 (2024-02-13 20:41 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.4 LTS
  uname: Linux 6.2.0-1019-azure #19~22.04.1-Ubuntu SMP Wed Jan 10 22:57:03 UTC 2024 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  2445 MHz        799 s          0 s         97 s       2754 s          0 s
       #2  3242 MHz        938 s          0 s         99 s       2614 s          0 s
       #3  2445 MHz        619 s          0 s        121 s       2885 s          0 s
       #4  2596 MHz       1073 s          0 s        104 s       2475 s          0 s
  Memory: 15.606903076171875 GB (13761.60546875 MB free)
  Uptime: 368.65 sec
  Load Avg:  1.7  0.99  0.41
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Baseline result

Benchmark Report for /home/runner/work/YAXArrays.jl/YAXArrays.jl

Job Properties

  • Time of benchmark: 22 Feb 2024 - 15:35
  • Package commit: ddfb9a
  • Julia commit: 7790d6
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["mapslices", "small"] 7.337 s (5%) 756.674 ms 1.04 GiB (1%) 10879134

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["mapslices"]

Julia versioninfo

Julia Version 1.10.1
Commit 7790d6f0641 (2024-02-13 20:41 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.4 LTS
  uname: Linux 6.2.0-1019-azure #19~22.04.1-Ubuntu SMP Wed Jan 10 22:57:03 UTC 2024 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  3249 MHz        846 s          0 s         99 s       2908 s          0 s
       #2  3242 MHz        993 s          0 s        103 s       2758 s          0 s
       #3  2445 MHz        706 s          0 s        124 s       2999 s          0 s
       #4  2445 MHz       1085 s          0 s        105 s       2666 s          0 s
  Memory: 15.606903076171875 GB (13800.34375 MB free)
  Uptime: 389.05 sec
  Load Avg:  1.5  0.99  0.42
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Runtime information

Runtime Info
BLAS #threads 2
BLAS.vendor() lbt
Sys.CPU_THREADS 4

lscpu output:

Architecture:                       x86_64
CPU op-mode(s):                     32-bit, 64-bit
Address sizes:                      48 bits physical, 48 bits virtual
Byte Order:                         Little Endian
CPU(s):                             4
On-line CPU(s) list:                0-3
Vendor ID:                          AuthenticAMD
Model name:                         AMD EPYC 7763 64-Core Processor
CPU family:                         25
Model:                              1
Thread(s) per core:                 2
Core(s) per socket:                 2
Socket(s):                          1
Stepping:                           1
BogoMIPS:                           4890.84
Flags:                              fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl tsc_reliable nonstop_tsc cpuid extd_apicid aperfmperf pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm cmp_legacy svm cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw topoext invpcid_single vmmcall fsgsbase bmi1 avx2 smep bmi2 erms invpcid rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 xsaves clzero xsaveerptr rdpru arat npt nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold v_vmsave_vmload umip vaes vpclmulqdq rdpid fsrm
Virtualization:                     AMD-V
Hypervisor vendor:                  Microsoft
Virtualization type:                full
L1d cache:                          64 KiB (2 instances)
L1i cache:                          64 KiB (2 instances)
L2 cache:                           1 MiB (2 instances)
L3 cache:                           32 MiB (1 instance)
NUMA node(s):                       1
NUMA node0 CPU(s):                  0-3
Vulnerability Gather data sampling: Not affected
Vulnerability Itlb multihit:        Not affected
Vulnerability L1tf:                 Not affected
Vulnerability Mds:                  Not affected
Vulnerability Meltdown:             Not affected
Vulnerability Mmio stale data:      Not affected
Vulnerability Retbleed:             Not affected
Vulnerability Spec rstack overflow: Mitigation; safe RET, no microcode
Vulnerability Spec store bypass:    Vulnerable
Vulnerability Spectre v1:           Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:           Mitigation; Retpolines, STIBP disabled, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds:                Not affected
Vulnerability Tsx async abort:      Not affected
Cpu Property Value
Brand AMD EPYC 7763 64-Core Processor
Vendor :AMD
Architecture :Unknown
Model Family: 0xaf, Model: 0x01, Stepping: 0x01, Type: 0x00
Cores 16 physical cores, 16 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 512, 32768) kbytes
64 byte cache line size
Address Size 48 bits virtual, 48 bits physical
SIMD 256 bit = 32 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC runs at constant rate (invariant from clock frequency)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8006986477

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.0%) to 68.192%
Totals Coverage Status
Change from base Build 8006343944: -1.0%
Covered Lines: 1207
Relevant Lines: 1770
💛 - Coveralls

@felixcremer
Copy link
Member

What exactly do you expect as output for your example in DD 641?
I tested

julia> broadcast_dims.(*, weights, g_ds)
╭───────────────────────────────────────╮
│ 4-element DimGroupByArray{YAXArray,1} │
├───────────────────────────────────────┴─────────────────────────────────────────────── dims ┐
  ↓ Ti Categorical{Symbol} [:Dec_Jan_Feb, :Mar_Apr_May, :Jun_Jul_Aug, :Sep_Oct_Nov] Unordered
├───────────────────────────────────────────────────────────────────────────────── metadata ┤
  Dict{Symbol, Any} with 1 entry:
  :groupby => :Ti=>CyclicBins(month; cycle=12, step=3, start=12)…
├─────────────────────────────────────────────────────────────────────────────── group dims ┤
  ↓ Ti, → X, ↗ Y, ⬔ Variable
└───────────────────────────────────────────────────────────────────────────────────────────┘
 :Dec_Jan_Feb  121×10×15×2 YAXArray
 :Mar_Apr_May   92×10×15×2 YAXArray
 :Jun_Jul_Aug   92×10×15×2 YAXArray
 :Sep_Oct_Nov   91×10×15×2 YAXArray

Which is the same that Raf tested for DimArrays and this works for me locally.
This is on the fc/metadata branch and DimensionalData main

@lazarusA lazarusA mentioned this pull request Feb 22, 2024
Merged
@lazarusA
Copy link
Collaborator Author

yeah... you are right... I just tested it directly on your branch, with those lines of code.

@lazarusA lazarusA deleted the revert-370-fc/metadata branch September 22, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lazarusA @coveralls @felixcremer