-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Metadata a type parameter of YAXArray #370
Conversation
This test should rather live in DimensionalData because mapslices of DimArray is implemented there.
This is similar to how DimArray handles that and allows to use DD Metadata types.
Benchmark resultJudge resultBenchmark Report for /home/runner/work/YAXArrays.jl/YAXArrays.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/YAXArrays.jl/YAXArrays.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/YAXArrays.jl/YAXArrays.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
|
Pull Request Test Coverage Report for Build 8005252794Details
💛 - Coveralls |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #370 +/- ##
=======================================
Coverage 68.43% 68.43%
=======================================
Files 12 12
Lines 1771 1771
=======================================
Hits 1212 1212
Misses 559 559 ☔ View full report in Codecov by Sentry. |
all tests passed. I will merge this. |
This is similarly done for DimArray. This allows to use the NoMetadata type from DimensionalData.LookupArray in a YAXArray which is used as a default in some DimensionalData functions.
This would close rafaqz/DimensionalData.jl#641
I also removed a test which should rather live in DimensionalData because it does not test YAXArray functionality.