max_cache human writing #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```max_cache``` in bits is fine, but not very human friendly. This is a downstream implementation of the YAXArraysToolbox package to get ```max_cache``` as e.g. ```max_cache="100MB"``` that can be useful for users of the YAXArrays package.
Update DAT.jl
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
Now this feature is non-breaking previous code.
|
Thanks a lot for the PR. Something seems to be strange since I can see a series of commits, but it looks like there are no changes to the files. Don't know if the error is on my side @felixcremer do you see proposed changes? |
dpabon
force-pushed
the
dpabon-patch-1
branch
from
ca40fa8 to
01123f2
Compare
|
Thanks Fabian, you're right, somehow I reverted the changes on the branch. Now you should be able to see the changes. |
Pull Request Test Coverage Report for Build 6301293873
💛 - Coveralls |
|
@dpabon please add some tests, if you can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
max_cachein bits is fine, but not very human friendly. This is a downstream implementation of the YAXArraysToolbox package to getmax_cacheas e.g.max_cache="100MB"that can be useful for users of the YAXArrays package.