Skip to content

Commit

Permalink
Remove the on_error keyword for parallel execution
Browse files Browse the repository at this point in the history
This makes sure, that the errors are actually thrown and not hidden.
  • Loading branch information
felixcremer committed Oct 16, 2024
1 parent 494f0f0 commit 6f1df3b
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/DAT/DAT.jl
Original file line number Diff line number Diff line change
Expand Up @@ -708,7 +708,7 @@ function runLoop(dc::DATConfig, showprog)
"YAXArrays is not loaded on all workers. Please run `@everywhere using YAXArrays` to fix.",
)
mapfun = showprog ? progress_pmap : pmap
mapfun(CachingPool(workers()),allRanges, on_error=identity) do r
m = mapfun(CachingPool(workers()),allRanges) do r
incaches, outcaches, args = getallargs(dc)
updateinars(dc, r, incaches)
if dc.ntr[myid()] > 1
Expand Down
10 changes: 10 additions & 0 deletions test/DAT/mapcube.jl
Original file line number Diff line number Diff line change
Expand Up @@ -60,4 +60,14 @@
r = mapCube(simple_fun, (a1, a2), indims=(indims, indims), outdims=outdims, max_cache = "0.1GB")
@test r.data == a1.data .+ permutedims(a2.data,(1,3,2))
end

@testset "Error shown in parallel" begin
x,y,z = X(1:4), Y(1:5), Z(1:6)
a1 = YAXArray((x,y,z), rand(4,5,6))
indims = InDims("x")
outdims = OutDims("x")
@test_throws Exception mapCube((xout, xin) -> xout .= foo(xin), a1; indims, outdims, ispar=false)
@test_throws CapturedException mapCube((xout, xin) -> xout .= foo(xin), a1; indims, outdims, ispar=true)

end
end

0 comments on commit 6f1df3b

Please sign in to comment.