Fix load_all of null documents #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think there are people who would like to use YAML's null as |
|
You mean with a custom constructor? Fair enough, let's go with an internal singleton object instead. |
GunnarFarneback
force-pushed
the
loading_null_documents
branch
from
3dbaac1 to
a9e8309
Compare
|
Yes, I have concerned about an unimplemented custom constructor which can use |
|
Can we resolve conflicts here/ |
GunnarFarneback
force-pushed
the
loading_null_documents
branch
from
a9e8309 to
677a340
Compare
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #226 by internally representing non-documents (e.g. whitespace and comments only) by
missing. (This could have used, but.missingseemed reasonably fitting for the purpose.)