Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New phone functions #106

Merged
merged 76 commits into from
Jan 2, 2024
Merged

New phone functions #106

merged 76 commits into from
Jan 2, 2024

Conversation

andrew-hoggins
Copy link
Collaborator

Sorry for the amount of commits. Should have got many of these in sooner.
Added a lot of new zoom phone functions and reworked other to make get-zoomphone* return data more natural to powershell.

Below is a list of the majority of functions wrote/reworked.

# Generic Phone
Get-ZoomPhoneCallingPlan
Get-ZoomPhoneNumber
Get-ZoomPhoneProvisioingTemplate

# Common Area Phone
Add-ZoomPhoneCommonAreaCallingPlan
Add-ZoomPhoneCommonAreaNumber
Get-ZoomPhoneCommonArea
Get-ZoomPhoneCommonAreaSettings
New-ZoomPhoneCommonArea
Remove-ZoomPhoneCommonArea
Remove-ZoomPhoneCommonAreaCallingPlan
Remove-ZoomPhoneCommonAreaNumber
Update-ZoomPhoneCommonArea

# Desk Phone
Add-ZoomPhoneDeviceAssignee
Get-ZoomPhoneDevice
Invoke-ZoomPhoneDeviceReboot
New-ZoomPhoneDevice
Remove-ZoomPhoneDevice
Remove-ZoomPhoneDeviceAssignee
Update-ZoomPhoneDevice
Update-ZoomPhoneDeviceProvisioningTemplate

# User Phone 
Add-ZoomPhoneUserCallingPlan
Add-ZoomPhoneUserNumber
Get-ZoomPhoneUser
Get-ZoomPhoneUserSettings
New-ZoomPhoneUser
Remove-ZoomPhoneUserCallingPlan
Remove-ZoomPhoneUserNumber
Update-ZoomPhoneUser
Update-ZoomPhoneUserCallingPlan
Update-ZoomPhoneUserSettings

# Phone Site
Get-ZoomPhoneSiteEmergencyAddress

Andrew Hoggins and others added 30 commits April 12, 2023 23:46
Added Zoomgov.com support
98f1963
Add User Zoom Phone Calling Plan modifiers.
36fa444
Added add/remove zoom phone numbers
377c66b
Added better error handling
4a32250
Added command to get list of numbers
499e146
New phones cmdlets added
1eb27e5
Added function for Zoom Emergency Addresses
33eb2e3
Consolidated get zoom site, added two new queries
cc27d71
Removed UserID array option
802082c
New parameter options for getting zoom numbers.
067cbff
Reworked paginatation queries
9eaed96
working on new zoom phone user module
fe1b903
Merge branch 'Update-ZoomPhoneUser' of https://github.com/andrew-hogg…
c942b87 
…ins/PSZoom into Update-ZoomPhoneUser
Split heavily reused code into Private module
1a7488a
Streamlined code using private cmdlet
9bad9b5
Broke out repeated used code into function.
41f4b81
Undated module to use new offload functions.
7bf39c6
Streamlined Get-ZoomPhoneCommonArea
1010179
Added whitelist for Get-ZoomItemFullDetails
1aac414
rename get-zoomphonenumbers to get-zoomphonenumber
297b160
Added function alias and reformated.
a2c9859
Added function alias & reformated scripts
4e5c50b
Standardizing on Singluar name rather than plural
76e1c6e
Refined function capabilities. Fixed some bugs.
ce46fc9
Initial push of new zoom phone functions.
bfd8f56
Resolves some logic issues with phone devices.
f68cb5a
Added unassigned & assigned filter
dbfecaf
Simplified function as original didn't work.
926adc0
added whatif passthru
ed91a05
added Get-Provisioningtemplate plus fixes
206095b
Andrew Hoggins and others added 22 commits December 30, 2023 23:45
your commit message
bd7f461
Fixed changes I used to test
187b3df
fixed changes I used for testing
2384777
Added export of funtion alias' as some modules were made singluar and…
1643e82 
… plural form was added as alias.
Fixed zoomgov APIconnection string
df55133
Fixed formatting on readme.md
c1ef6c7
Fixed error with request due to extra appended "/"
a556754
import all alias' so that renamed functions are compatible with how u…
0cdedf5 
…sers currently call them.
Foxed two modules named the same.
85bf2ae
Fixed error with validating the string length of user's input. Added …
a92d841 
…max length.
Added expand property for better user interaction.
90ebe59
@andrew-hoggins
Updated help info for a few functions
d482004
Added better error handling to funtion
39eefcc
Added better help info
221a399
Match property names of other functions
4b66b13
Fixed some logic in function
2dd8e8a
Fixed logic issue preventing unassignment
47072ae
Added more details to whatif statement
d3f3d8b
Fixing whatif confirm logic
8562f07
Fixed missing mandatory parameter for function
03636e4
Changed madatory parameter.
d9237df
Updated Readme with new functions
35d7664
@andrew-hoggins
Copy link
Collaborator Author

FYI, I noticed the zoomgov.com support broke after Issue #98 was resolved.
I fixed and tested with both zoom.us and zoomgov.com with the command the user reported to have issues with.
All seems good.

@JosephMcEvoy JosephMcEvoy self-requested a review January 2, 2024 00:10
@JosephMcEvoy JosephMcEvoy self-assigned this Jan 2, 2024
@JosephMcEvoy
Copy link
Owner

Wow, nice commit! Update-ZoomPhoneUser is a doozy. I know how much work it can be to get these cmdlets done. Thank you for the contribution.

@JosephMcEvoy JosephMcEvoy merged commit d85bf9d into JosephMcEvoy:master Jan 2, 2024
JosephMcEvoy
JosephMcEvoy reviewed Jan 2, 2024
View reviewed changes
Copy link
Owner

@JosephMcEvoy JosephMcEvoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@andrew-hoggins andrew-hoggins deleted the New-Phone-Functions branch January 2, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JosephMcEvoy JosephMcEvoy JosephMcEvoy left review comments

Assignees

@JosephMcEvoy JosephMcEvoy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrew-hoggins @JosephMcEvoy