Add hellomicroverse page with linter checks #1
Conversation
create a .gitignore file for the new branch
add a linter for html and css to assist in checking the html and css for errors
update .gitignore to ignore the linters for html and css
add index.html file with a header containing h1 element as Hello Microverse!
add styling for the header
Add test.md file. This is to be ignored in the .gitignore
There was a problem hiding this comment.
First of all Welcome to Microverse 🎉 💐
Required Changes ♻️
Hey @JonahKayizzi 👋
Highlights 🥇
✔️ Meaningful commits
✔️ Added .gitignore
✔️ Following Github Flow
Good job on implementing some of the requirements, there are some issues that you still need to work on to go to the next project but you are almost there! 😊
Optional Suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding 👏 👏 👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @HAMMAS-SALEEM in your question so I can receive the notification. Otherwise reach out to me on slack which is more fast. You can reach out to me on slack by searching my name in full-time-students channel 👍
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
test.md
Outdated
| @@ -0,0 +1 @@ | |||
|
|
|||
There was a problem hiding this comment.
- Your test.md file is still in your repository. It should be ignored by .gitignore. 😊 It is happening because you have created your .gitignore file after creating the test.md file. 🤔
- For now you need to delete your test.md file from your local repository. 😊
- Then create it again to check if the gitignore is ignoring it.
Please do the changes and make sure your gitignore should avoid this test.md file from going into your Github Repository 😊
There was a problem hiding this comment.
Thanks for this wonderful feedback 👍 . The test.md file has been deleted from the repository
| ## 📝 License | ||
|
|
||
| This project is [MIT](./LICENSE) licensed. |
There was a problem hiding this comment.
- It would be nice if you add a license file in your repository you can add using this template 😊
- Don't forget to add your name, current year, and app type in your MIT.md file after adding it in your project 👍
Note: This is the license file of your project so please take it seriously 🤔
There was a problem hiding this comment.
A license has also been added to the repository. Thanks for this tip 👍
delete test.md file so that .gitignore automatically ignores it on next commit
There was a problem hiding this comment.
Hi @JonahKayizzi ,
I'm Levy, your PR reviewer
Excellent, you have addressed all required changes.
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Status: APPROVED 🔥 🔥
Highlights 💪
- All linters are passing ✔️
- Your README file is professional ✔️
- Correct usage of Github flow ✔️
- Good PR description ✔️
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
- [OPTIONAL] Kindly make sure to write your commit message in imperative tense in future projects and capitalized it. Please check this lesson to understand it clearly.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @levy002 in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
This pull request comprises the following changes;