Skip to content

Commit

Permalink
Merge pull request #11 from JoinColony/feat/expenditure-metadata-muta…
Browse files Browse the repository at this point in the history
…tion

Allow expenditure metadata mutation, fix other metadata mutations checks
  • Loading branch information
jakubcolony authored Feb 16, 2024
2 parents f4b74a3 + f740516 commit a0bbc66
Show file tree
Hide file tree
Showing 2 changed files with 83 additions and 57 deletions.
136 changes: 79 additions & 57 deletions src/routes/graphql/mutations.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,7 @@ import { ColonyRole } from '@colony/core';

import { logger, detectOperation, tryFetchGraphqlQuery } from '~helpers';
import { MutationOperations } from '~types';
import {
getColonyAction,
getColonyRole,
getColonyTokens,
} from '~queries';
import { getColonyAction, getColonyRole, getColonyTokens } from '~queries';

const hasMutationPermissions = async (
operationName: string,
Expand All @@ -23,88 +19,97 @@ const hasMutationPermissions = async (
*/
case MutationOperations.CreateUniqueUser:
case MutationOperations.UpdateUserProfile: {
const { input: { id }} = JSON.parse(variables);
const {
input: { id },
} = JSON.parse(variables);
return id?.toLowerCase() === userAddress?.toLowerCase();
}
case MutationOperations.CreateTransaction:
case MutationOperations.UpdateTransaction: {
const { input: { from } } = JSON.parse(variables);
const {
input: { from },
} = JSON.parse(variables);
return from?.toLowerCase() === userAddress?.toLowerCase();
}
case MutationOperations.CreateUserTokens: {
const { input: { userID } } = JSON.parse(variables);
const {
input: { userID },
} = JSON.parse(variables);
return userID?.toLowerCase() === userAddress?.toLowerCase();
}
/*
* Colony
*/
case MutationOperations.CreateColonyMetadata:
case MutationOperations.UpdateColonyMetadata: {
const { input: { id: colonyAddress } } = JSON.parse(variables);
const {
input: { id: colonyAddress },
} = JSON.parse(variables);
try {
const data = await tryFetchGraphqlQuery(
getColonyRole,
{ combinedId: `${colonyAddress}_1_${userAddress}_roles` },
);
const data = await tryFetchGraphqlQuery(getColonyRole, {
combinedId: `${colonyAddress}_1_${userAddress}_roles`,
});
return !!data[`role_${ColonyRole.Root}`];
} catch (error) {
// silent
return false;
}
}
case MutationOperations.CreateColonyContributor: {
const { input: { contributorAddress } } = JSON.parse(variables);
const {
input: { contributorAddress },
} = JSON.parse(variables);
return contributorAddress?.toLowerCase() === userAddress?.toLowerCase();
}
case MutationOperations.UpdateColonyContributor: {
const { input: { id: combinedContributorId } } = JSON.parse(variables);
const {
input: { id: combinedContributorId },
} = JSON.parse(variables);
const [, contributorWalletAddress] = combinedContributorId.split('_');
return contributorWalletAddress?.toLowerCase() === userAddress?.toLowerCase();
return (
contributorWalletAddress?.toLowerCase() === userAddress?.toLowerCase()
);
}
case MutationOperations.CreateColonyEtherealMetadata: {
const { input: { initiatorAddress } } = JSON.parse(variables);
const {
input: { initiatorAddress },
} = JSON.parse(variables);
return initiatorAddress?.toLowerCase() === userAddress?.toLowerCase();
}
/*
* Domains
*/
case MutationOperations.CreateDomain: {
const { input: { colonyId: colonyAddress } } = JSON.parse(variables);
const {
input: { colonyId: colonyAddress },
} = JSON.parse(variables);
try {
const data = await tryFetchGraphqlQuery(
getColonyRole,
{ combinedId: `${colonyAddress}_1_${userAddress}_roles` },
);
const data = await tryFetchGraphqlQuery(getColonyRole, {
combinedId: `${colonyAddress}_1_${userAddress}_roles`,
});
return !!data[`role_${ColonyRole.Architecture}`];
} catch (error) {
// silent
return false;
}
}
case MutationOperations.CreateDomainMetadata:
case MutationOperations.UpdateDomainMetadata: {
const { input: { id: combinedId } } = JSON.parse(variables);
try {
const [colonyAddress] = combinedId.split('_');
const data = await tryFetchGraphqlQuery(
getColonyRole,
{ combinedId: `${colonyAddress}_1_${userAddress}_roles` },
);
return !!data[`role_${ColonyRole.Architecture}`];
} catch (error) {
// silent
return false;
}
return true;
}
/*
* Actions, Mutations
*/
case MutationOperations.CreateAnnotation:
case MutationOperations.CreateColonyActionMetadata: {
const { input: { id: actionId } } = JSON.parse(variables);
const {
input: { id: actionId },
} = JSON.parse(variables);
try {
const data = await tryFetchGraphqlQuery(getColonyAction, { actionId });
return data.initiatorAddress?.toLowerCase() === userAddress?.toLowerCase();
const data = await tryFetchGraphqlQuery(getColonyAction, {
actionId,
});
return (
data.initiatorAddress?.toLowerCase() === userAddress?.toLowerCase()
);
} catch (error) {
// silent
return false;
Expand All @@ -114,28 +119,32 @@ const hasMutationPermissions = async (
* Tokens
*/
case MutationOperations.CreateColonyTokens: {
const { input: { colonyID: colonyAddress } } = JSON.parse(variables);
const {
input: { colonyID: colonyAddress },
} = JSON.parse(variables);
try {
const data = await tryFetchGraphqlQuery(
getColonyRole,
{ combinedId: `${colonyAddress}_1_${userAddress}_roles` },
);
const data = await tryFetchGraphqlQuery(getColonyRole, {
combinedId: `${colonyAddress}_1_${userAddress}_roles`,
});
return !!data[`role_${ColonyRole.Root}`];
} catch (error) {
// silent
return false;
}
}
case MutationOperations.DeleteColonyTokens: {
const { input: { id: tokenColonyId } } = JSON.parse(variables);
const {
input: { id: tokenColonyId },
} = JSON.parse(variables);
try {
const tokenData = await tryFetchGraphqlQuery(getColonyTokens, { tokenColonyId });
const tokenData = await tryFetchGraphqlQuery(getColonyTokens, {
tokenColonyId,
});

if (tokenData?.colonyID) {
const data = await tryFetchGraphqlQuery(
getColonyRole,
{ combinedId: `${tokenData.colonyID}_1_${userAddress}_roles` },
);
const data = await tryFetchGraphqlQuery(getColonyRole, {
combinedId: `${tokenData.colonyID}_1_${userAddress}_roles`,
});
return !!data[`role_${ColonyRole.Root}`];
}
return false;
Expand All @@ -144,6 +153,18 @@ const hasMutationPermissions = async (
return false;
}
}
/**
* Expenditures
*/
case MutationOperations.CreateExpenditureMetadata: {
return true;
}
/**
* Metadata can be created as part of the motion process, so we need to allow
* those mutations even for users with no permissions
*/
case MutationOperations.CreateColonyMetadata:
case MutationOperations.CreateDomainMetadata:
/*
* Always allow, it's just updating cache, anybody can trigger it
*/
Expand All @@ -152,19 +173,22 @@ const hasMutationPermissions = async (
case MutationOperations.GetTokenFromEverywhere:
case MutationOperations.UpdateContributorsWithReputation: {
return true;
};
}
default: {
return false;
}
}
} catch (error) {
logger(`Error when attempting to check if user ${userAddress} can execute mutation ${operationName} with variables ${variables}`, error);
logger(
`Error when attempting to check if user ${userAddress} can execute mutation ${operationName} with variables ${variables}`,
error,
);
/*
* If anything fails just prevent the mutation from executing
*/
return false;
}
}
};

const addressCanExecuteMutation = async (
request: Request,
Expand All @@ -177,10 +201,8 @@ const addressCanExecuteMutation = async (
}
const canExecuteAllOperations = await Promise.all(
operations.map(
async (operationName) => await hasMutationPermissions(
operationName,
request,
),
async (operationName) =>
await hasMutationPermissions(operationName, request),
),
);
return canExecuteAllOperations.every((canExecute) => canExecute);
Expand Down
4 changes: 4 additions & 0 deletions src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@ export enum MutationOperations {
GetTokenFromEverywhere = 'getTokenFromEverywhere',
CreateColonyTokens = 'createColonyTokens',
DeleteColonyTokens = 'deleteColonyTokens',
/*
* Expenditures
*/
CreateExpenditureMetadata = 'createExpenditureMetadata',
}

export enum HttpStatuses {
Expand Down

0 comments on commit a0bbc66

Please sign in to comment.