Skip to content

Commit

Permalink
fixed numpy -/~ issue; corrected doc text of p_any; version 4.1
Browse files Browse the repository at this point in the history
  • Loading branch information
JohannesBuchner committed Dec 21, 2018
1 parent e463243 commit 40f920c
Show file tree
Hide file tree
Showing 5 changed files with 87 additions and 35 deletions.
2 changes: 2 additions & 0 deletions Changelog
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ Version 4.0:

Added pandas-based API
Improved hashing procedure: faster and less memory use.

Fixed numpy deprecation issue (logical not is ~) (4.1).

Version 3.0:

Expand Down
116 changes: 83 additions & 33 deletions doc/nway-manual.lyx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#LyX 2.2 created this file. For more info see http://www.lyx.org/
\lyxformat 508
#LyX 2.3 created this file. For more info see http://www.lyx.org/
\lyxformat 544
\begin_document
\begin_header
\save_transient_properties true
Expand Down Expand Up @@ -67,6 +67,8 @@
\font_osf false
\font_sf_scale 100 100
\font_tt_scale 100 100
\use_microtype false
\use_dash_ligatures true
\graphics default
\default_output_format default
\output_sync 0
Expand Down Expand Up @@ -106,6 +108,7 @@
\suppress_date false
\justification true
\use_refstyle 1
\use_minted 0
\index Index
\shortcut idx
\color #008000
Expand All @@ -116,7 +119,10 @@
\tocdepth 3
\paragraph_separation indent
\paragraph_indentation default
\quotes_language english
\is_math_indent 0
\math_numbering_side default
\quotes_style english
\dynamic_quotes 0
\papercolumns 1
\papersides 1
\paperpagestyle default
Expand Down Expand Up @@ -2242,34 +2248,39 @@ COSMOS_IRAC.fits, COSMOS_OPTICAL.fits and COSMOS_XMM.fits
\begin_inset CommandInset citation
LatexCommand cite
key "2018MNRAS.473.4937S"
literal "true"

\end_inset

, extracted from
\begin_inset CommandInset citation
LatexCommand cite
key "Sanders2007"
literal "true"

\end_inset

/
\begin_inset CommandInset citation
LatexCommand cite
key "McCracken2007"
literal "true"

\end_inset

,
\begin_inset CommandInset citation
LatexCommand cite
key "Ilbert2010"
literal "true"

\end_inset

and
\begin_inset CommandInset citation
LatexCommand cite
key "Brusa2010"
literal "true"

\end_inset

Expand Down Expand Up @@ -3180,6 +3191,7 @@ status open
\begin_inset CommandInset citation
LatexCommand citet
key "Budavari2008"
literal "true"

\end_inset

Expand Down Expand Up @@ -3278,7 +3290,7 @@ status open

\series default
: For each entry in the primary catalogue (e.g.
A) the probability that no association is the correct one is computed.
A) the probability that one of the association is the correct one is computed.
Because every catalogue is limited by its depth, it is possible that the
true counterpart has not been found yet.
Our testing suggest that the
Expand All @@ -3298,50 +3310,55 @@ reference "sec:Best-practice-matching"
\end_inset

explains how to calibrate a threshold.
\begin_inset Newline newline
\end_inset
\end_layout

\begin_layout Enumerate

\series bold
\begin_inset ERT
status open

\begin_layout Plain Layout


\backslash
mycaution{
code{
\end_layout

\end_inset

High
p_i
\begin_inset ERT
status open

\begin_layout Plain Layout


\backslash
code{
}
\end_layout

\end_inset

p_any

\series default
: For each possible association for each entry in the primary catalogue
(e.g.
A), the relative probability is computed.
Our testing suggest that secure, pure catalogue
\series bold
should keep only associations where
\begin_inset ERT
status open

\begin_layout Plain Layout

}

\backslash
code{
\end_layout

\end_inset

values by themselves do not necessarily mean that the counterpart is ruled
out.
It can also mean that there is not enough evidence/information to declare
it a counterpart.
p_i>=0.1
\begin_inset ERT
status open

Expand All @@ -3352,12 +3369,29 @@ status open

\end_inset

.
Secondary solutions down to 0.1 may be interesting.
These thresholds may depend on the application – please report what your
testing gives.
\series default

\begin_inset Newline newline
\end_inset


\begin_inset ERT
status open

\begin_layout Plain Layout


\backslash
mycaution{
\end_layout

\begin_layout Enumerate
\end_inset

\series bold
Low
\begin_inset ERT
status open

Expand All @@ -3370,7 +3404,7 @@ code{

\end_inset

p_i
p_any
\begin_inset ERT
status open

Expand All @@ -3381,14 +3415,7 @@ status open

\end_inset


\series default
: For each possible association for each entry in the primary catalogue
(e.g.
A), the relative probability is computed.
Our testing suggest that secure, pure catalogue
\series bold
should keep only associations where
and
\begin_inset ERT
status open

Expand All @@ -3401,7 +3428,7 @@ code{

\end_inset

p_i>=0.1
p_i
\begin_inset ERT
status open

Expand All @@ -3412,10 +3439,21 @@ status open

\end_inset

.
Secondary solutions down to 0.1 may be interesting.
These thresholds may depend on the application – please report what your
testing gives.
values by themselves do not necessarily mean that the counterpart is ruled
out.
It can also mean that there is not enough evidence/information to declare
it a counterpart.
\begin_inset ERT
status open

\begin_layout Plain Layout

}
\end_layout

\end_inset


\end_layout

\begin_layout Enumerate
Expand Down Expand Up @@ -4705,6 +4743,7 @@ Keep in mind that a prior created from a different data set can only be
\begin_inset CommandInset citation
LatexCommand cite
key "2018MNRAS.473.4937S"
literal "true"

\end_inset

Expand Down Expand Up @@ -4749,6 +4788,7 @@ nway~
\begin_inset CommandInset citation
LatexCommand cite
key "2018MNRAS.473.4937S"
literal "true"

\end_inset

Expand Down Expand Up @@ -5353,6 +5393,7 @@ If each catalogue covers the same area with some respective, homogeneous
LatexCommand citep
after "eq. 25"
key "Budavari2008"
literal "true"

\end_inset

Expand Down Expand Up @@ -5437,6 +5478,7 @@ We now extend the approach of
\begin_inset CommandInset citation
LatexCommand citet
key "Budavari2008"
literal "true"

\end_inset

Expand All @@ -5445,6 +5487,7 @@ key "Budavari2008"
\begin_inset CommandInset citation
LatexCommand citet
key "Budavari2008"
literal "true"

\end_inset

Expand Down Expand Up @@ -5497,6 +5540,7 @@ In comparison to our method, the method of
\begin_inset CommandInset citation
LatexCommand citet
key "Budavari2008"
literal "true"

\end_inset

Expand Down Expand Up @@ -5646,6 +5690,7 @@ reference "sec:mag-priors"
\begin_inset CommandInset citation
LatexCommand citet
key "Budavari2008"
literal "true"

\end_inset

Expand All @@ -5655,6 +5700,7 @@ key "Budavari2008"
\begin_inset CommandInset citation
LatexCommand citealp
key "Pineau2016"
literal "true"

\end_inset

Expand Down Expand Up @@ -5873,6 +5919,7 @@ Astronomical objects of various classes often show distinct color and magnitude
LatexCommand citep
before "e.g."
key "Brusa2005,Brusa2007"
literal "true"

\end_inset

Expand All @@ -5884,6 +5931,7 @@ key "Brusa2005,Brusa2007"
\begin_inset CommandInset citation
LatexCommand citealp
key "SutherlandSaunders1992"
literal "true"

\end_inset

Expand Down Expand Up @@ -6203,6 +6251,7 @@ First, possible associations are found.
\begin_inset CommandInset citation
LatexCommand citep
key "Gorski2005"
literal "true"

\end_inset

Expand Down Expand Up @@ -6262,6 +6311,7 @@ correcting for unrelated associations
\begin_inset CommandInset citation
LatexCommand cite
key "2018MNRAS.473.4937S"
literal "true"

\end_inset

Expand Down
Binary file modified doc/nway-manual.pdf
Binary file not shown.
2 changes: 1 addition & 1 deletion nway.py
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,7 @@ def error(self, message):

# cut away poor posteriors if requested
if min_prob > 0:
mask = -(prob_this_match < min_prob)
mask = ~(prob_this_match < min_prob)
print(' cutting away %d (below p_i minimum)' % (len(mask) - mask.sum()))

for c in columns:
Expand Down
2 changes: 1 addition & 1 deletion nwaylib/VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
4.0
4.1

0 comments on commit 40f920c

Please sign in to comment.