Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Import Statement and Improve Test Coverage for secured Package #19

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

Joaopeuko
Copy link
Owner

Description

This PR simplifies the import statement for the Secured class and adds unit tests to achieve almost 100% coverage for secured/secured.py.


Related Issue


Changes Made

  • Simplified the import statement for the Secured class from from secured.secured import Secured to from secured import Secured.
  • Updated secured/__init__.py to include Secured in __all__ for a cleaner import.
  • Added comprehensive unit tests for the Secured class.

@Joaopeuko Joaopeuko self-assigned this Jun 25, 2024
@Joaopeuko Joaopeuko linked an issue Jun 25, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.21%. Comparing base (0a096c7) to head (5433b49).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #19       +/-   ##
===========================================
+ Coverage   77.60%   99.21%   +21.61%     
===========================================
  Files           4        5        +1     
  Lines         125      127        +2     
===========================================
+ Hits           97      126       +29     
+ Misses         28        1       -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Joaopeuko Joaopeuko merged commit 08f05b0 into main Jun 25, 2024
4 checks passed
@Joaopeuko Joaopeuko deleted the 18-simplify-import-statement-for-secured-class branch June 25, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify Import Statement for Secured Class
2 participants