Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for lg webos tv #371

Merged
merged 10 commits into from
Aug 23, 2024
Merged

fix for lg webos tv #371

merged 10 commits into from
Aug 23, 2024

Conversation

dheerajv4855
Copy link
Contributor

added flag based response change for webos so that it wont affect the other functionality
we cab use --webos flag to serve for lg tv

rabilrbl and others added 3 commits August 6, 2024 21:43
@rabilrbl @dependabot
Merge pull request JioTV-Go#366 from rabilrbl/develop
8c370c8 
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
fix: Increase buffer size when downloading binary in update command (JioTV-Go#365)
@github-actions
Bump version to v3.8.0
809f9fe
fix for lg webos tv
5f8fb7f
@dheerajv4855 dheerajv4855 mentioned this pull request Aug 9, 2024
Closed
3 tasks
@rabilrbl
Copy link
Collaborator

rabilrbl commented Aug 9, 2024 •
edited
Loading

Explain your PR. Why u disabling helmet and a ETAG middleware?
And what does c.Locals("webosMode", webosMode) do?

@dheerajv4855
Copy link
Contributor Author

helmet and ETAG middleware's are modifiying the response Header which is causing the issue
to properly work on webos, Response header must contain Transfer-Encoding: "chunked" which is not happening even if we send as stream of data but if i disable those two middleware's it is working
i am aware that helmet provides extra security to api but what if it is not allowing api to work on webos
and those two middleware's will be excluded only in case of webos flag

c.Locals("webosMode", webosMode)
is only to pass the flag value webosMode to fiber context
so that we can retrieve that flag value anywhere in fiber handler
which i am doing in handler.ChannelsHandler function
i hope it is clear now
JFYI this change is also working on android devices. i mean if we pass flag --webos and stream in android tv there also it works

@rabilrbl
Copy link
Collaborator

It's better if we disable it for all devices, better if we remove it completely as I have seen it causing issues.

So remove all flags and simply delete those middleware calls

@rabilrbl rabilrbl linked an issue Aug 10, 2024 that may be closed by this pull request
feat: Add support for LG WebOS tv #354
Closed
3 tasks
@rabilrbl
Copy link
Collaborator

@dheerajv4855 Will u modify this PR or close it?

@dheerajv4855
Copy link
Contributor Author

hi @rabilrbl , will modify this PR to remove those middleware
will update today or tomorrow

@dheerajv4855
Copy link
Contributor Author

hi @rabilrbl
updated the PR by removing etag, helmet

rabilrbl
rabilrbl requested changes Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@rabilrbl rabilrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address these changes

go.mod Outdated Show resolved Hide resolved
internal/handlers/handlers.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@rabilrbl rabilrbl changed the base branch from main to develop August 16, 2024 04:26
dj and others added 2 commits August 17, 2024 12:05
reverted go version is mod file to 1.22
35c593b
@dheerajv4855 @rabilrbl
Update main.go
9684c8d 
Co-authored-by: Mohammed Rabil <rabilrbl7@gmail.com>
rabilrbl
rabilrbl requested changes Aug 22, 2024
View reviewed changes
internal/handlers/handlers.go Outdated Show resolved Hide resolved
rabilrbl and others added 2 commits August 22, 2024 19:56
@rabilrbl
Merge branch 'develop' into main
abac5fd
@dheerajv4855 @rabilrbl
Update internal/handlers/handlers.go
92cd701 
Co-authored-by: Mohammed Rabil <rabilrbl7@gmail.com>
rabilrbl
rabilrbl requested changes Aug 23, 2024
View reviewed changes
internal/handlers/handlers.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
rabilrbl
rabilrbl approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@rabilrbl rabilrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Approved.
I'll test this m3u generation and merge this

@rabilrbl rabilrbl merged commit a6e11b2 into JioTV-Go:develop Aug 23, 2024
7 of 9 checks passed
rabilrbl added a commit that referenced this pull request Aug 24, 2024
@rabilrbl
Merge pull request #389 from rabilrbl/develop
2182e71 
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Mohammed Rabil <rabilrbl7@gmail.com>
Co-authored-by: Mohammed Rabil <mail@rabil.me>
Co-authored-by: GitHub Action <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dj <dj@djs-Mac-Pro.local>
Co-authored-by: dheerajv4855 <48526859+dheerajv4855@users.noreply.github.com>
fix for lg webos tv (#371)
itsyourap pushed a commit to JFC-Group/JF-JioTV that referenced this pull request Sep 19, 2024
@dheerajv4855 @rabilrbl
@dependabot @github-actions @itsyourap
fix for lg webos tv (JioTV-Go#371)
cb5c8a4 
Co-authored-by: Mohammed Rabil <rabilrbl7@gmail.com>
Co-authored-by: Mohammed Rabil <mail@rabil.me>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: GitHub Action <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dj <dj@djs-Mac-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rabilrbl rabilrbl rabilrbl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Add support for LG WebOS tv
2 participants
@dheerajv4855 @rabilrbl