-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(manager): add translated strings for the new server tab #2352
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, but once resolved LGTM
} | ||
}, | ||
"server_view_access_keys_as_count_column_header": { | ||
"description": "Header: Total ASes", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're going to have to add some more info here about what AS stands for, otherwise the translators won't know what this means.
"message": "This shows the number of different Autonomous Systems (ASes) that connected to the server using this key over the last 30 days. An AS is a network that’s typically run by one organization" | ||
}, | ||
"server_view_access_keys_usage_limit": { | ||
"description": "80%+ used", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add some more context? It might matter what this is in reference to.
} | ||
}, | ||
"server_view_server_metrics_bandwidth_as_breakdown": { | ||
"description": "Total bandwidth AS breakdown", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, add info on this acronym for translators.
"message": "This shows the total time users were connected to the server over the last 30 days. It is calculated by adding up the connection time (Tunnel Time) for each device." | ||
}, | ||
"server_view_server_metrics_tunnel_time_as_breakdown": { | ||
"description": "Tunnel Time ASl breakdown", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"description": "Tunnel Time ASl breakdown", | |
"description": "Tunnel Time AS breakdown", |
But also add AS info.
"message": "Devices" | ||
}, | ||
"server_view_server_metrics_devices_as_breakdown": { | ||
"description": "Devices AS breakdown", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
}, | ||
"server_view_server_metrics_devices_as_breakdown_unit_label": { | ||
"description": "Devices AS unit", | ||
"message": "Devices" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the same as the server_view_server_metrics_devices_unit_label
. Is that right?
"message": "Devices" | ||
}, | ||
"server_view_server_metrics_detailed_server_metrics_link": { | ||
"description": "Pointer to HC for 3P metrics", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to avoid acronyms to help translators. How about "Text of a link to a help center article that contains more information on how to access more detailed metrics" or something
No description provided.