Add arm64 Linux version of client #2342
Open
+66
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
jyyi1
requested changes
Jan 22, 2025
There was a problem hiding this comment.
Thanks for the update! We're currently rewriting the routing on Linux (see issue #2312). This might conflict with your changes.
In future versions, we'll be removing AppImage and some related components, includingOutlineProxyController. Please make your updates to the .deb target instead. And make sure to test it on a Ubuntu machine.
Also, it's important that we can build the Linux version from macOS, as that's what we use for development. Please make sure the cross-compilation also works.
| @@ -65,6 +65,10 @@ tasks: | |||
| desc: "Build the tun2socks binary and library for Linux" | |||
| cmds: [{task: electron, vars: {TARGET_OS: "linux", TARGET_ARCH: "amd64"}}] | |||
|
|
|||
| linux_arm64: | |||
There was a problem hiding this comment.
Have you tried to build it from macOS, will this work?
There was a problem hiding this comment.
I don't have any macOS hw, so I can't check this
jyyi1
reviewed
Jan 24, 2025
| run: | | ||
| sudo apt install ruby | ||
| sudo gem install fpm | ||
| export USE_SYSTEM_FPM=true && export GEM_HOME="$(ruby -e 'puts Gem.user_dir')" && export PATH="$PATH:$GEM_HOME/bin" |
There was a problem hiding this comment.
Similar as above, please remove these scripts from the CI job, and add instructions/build scripts to the actual action (e.g. ./client/electron/build.action.mjs).
Please also illustrate why these steps are required.
|
@jyyi1 I can fix minor issues, but I'm not sure if it makes sense for now. There is critical problems that I can't solve: There is options/workarounds:
It's my 1st attempt to build/improve electron app - so: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure that it's best solution, but it's working example.
It was based on my previous build instruction: #816 (comment)
But improved + added arm64 Linux CI with GitHub-hosted runner:
https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#standard-github-hosted-runners-for-public-repositories