Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 QD-10767 Update submodules when checkout performed #519

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

AndreiIurko
Copy link
Contributor

When checkout performed during scoped script or full history script submodules are not updated and this may cause broken analysis. This commit should fix the issue

@AndreiIurko AndreiIurko requested a review from hybloid February 16, 2025 19:40
Copy link

github-actions bot commented Feb 16, 2025

Qodana for Go

8 new problems were found

Inspection name Severity Problems
Constant condition 🔶 Warning 4
Potential nil dereference 🔶 Warning 2
Error may be not nil 🔶 Warning 1
Comment of exported element starts with the incorrect name ◽️ Notice 1

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link
Contributor

@hybloid hybloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comment above. overall looks good

@AndreiIurko AndreiIurko force-pushed the iurko/update-submodules-in-scoped branch from cd82cd3 to 50e4576 Compare February 17, 2025 08:57
@AndreiIurko AndreiIurko requested a review from hybloid February 17, 2025 09:08
Copy link
Contributor

@hybloid hybloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AndreiIurko AndreiIurko merged commit 1a106ab into main Feb 17, 2025
6 checks passed
AndreiIurko added a commit that referenced this pull request Feb 18, 2025
…d scoped script (#519)

Co-authored-by: Andrei Iurko <andrei.iurko@jetbrains.com>
AndreiIurko added a commit that referenced this pull request Feb 18, 2025
…d scoped script (#519) (#521)

Co-authored-by: Andrei Iurko <andrei.iurko@jetbrains.com>
MekhailS added a commit that referenced this pull request Feb 19, 2025
…0767 Update submodules when checkout performed in full history and scoped script (#519)"

This reverts commit 1a106ab.
MekhailS added a commit that referenced this pull request Feb 19, 2025
MekhailS added a commit that referenced this pull request Feb 20, 2025
…0767 Update submodules when checkout performed in full history and scoped script (#519)"

This reverts commit 1a106ab.
MekhailS added a commit that referenced this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants