🐛 QD-10767 Update submodules when checkout performed in full history …

…and scoped script (#519)

core/system.go

@@ -235,7 +235,7 @@ func runWithFullHistory(ctx context.Context, c corescan.Context, startHash strin
 		counter++
 
 		msg.WarningMessage("[%d/%d] Running analysis for revision %s", counter+1, allCommits, revision)
-		err = git.Checkout(c.ProjectDir(), revision, true, c.LogDir())
+		err = git.CheckoutAndUpdateSubmodule(c.ProjectDir(), revision, true, c.LogDir())
 		if err != nil {
 			log.Fatal(err)
 		}
@@ -244,7 +244,7 @@ func runWithFullHistory(ctx context.Context, c corescan.Context, startHash strin
 		contextForAnalysis := c.WithVcsEnvForFullHistoryAnalysisIteration(remoteUrl, branch, revision)
 		exitCode = runQodana(ctx, contextForAnalysis)
 	}
-	err = git.Checkout(c.ProjectDir(), branch, true, c.LogDir())
+	err = git.CheckoutAndUpdateSubmodule(c.ProjectDir(), branch, true, c.LogDir())
 	if err != nil {
 		log.Fatal(err)
 	}
@@ -274,7 +274,7 @@ func runScopeScript(ctx context.Context, c corescan.Context, startHash string) i
 	}()
 
 	runFunc := func(hash string, c corescan.Context) (bool, int) {
-		e := git.Checkout(c.ProjectDir(), hash, true, c.LogDir())
+		e := git.CheckoutAndUpdateSubmodule(c.ProjectDir(), hash, true, c.LogDir())
 		if e != nil {
 			log.Fatalf("Cannot checkout commit %s: %v", hash, e)
 		}

platform/git/git.go

@@ -62,8 +62,18 @@ func ResetBack(cwd string, logdir string) error {
 	return err
 }
 
-// Checkout checks out the given commit / branch.
-func Checkout(cwd string, where string, force bool, logdir string) error {
+// See QD-10767 case for why update submodule is needed
+func CheckoutAndUpdateSubmodule(cwd string, where string, force bool, logdir string) error {
+	err := checkout(cwd, where, force, logdir)
+	if err != nil {
+		return err
+	}
+	err = submoduleUpdate(cwd, force, logdir)
+	return err
+}
+
+// checkout checks out the given commit / branch.
+func checkout(cwd string, where string, force bool, logdir string) error {
 	var err error
 	if !force {
 		_, _, err = gitRun(cwd, []string{"checkout", where}, logdir)
@@ -73,6 +83,17 @@ func Checkout(cwd string, where string, force bool, logdir string) error {
 	return err
 }
 
+// GitSubmoduleUpdate updates submodules according to current revision
+func submoduleUpdate(cwd string, force bool, logdir string) error {
+	if !force {
+		_, _, err := gitRun(cwd, []string{"submodule", "update", "--init", "--recursive"}, logdir)
+		return err
+	} else {
+		_, _, err := gitRun(cwd, []string{"submodule", "update", "--init", "--recursive", "--force"}, logdir)
+		return err
+	}
+}
+
 // Clean cleans the git repository.
 func Clean(cwd string, logdir string) error {
 	_, _, err := gitRun(cwd, []string{"clean", "-fdx"}, logdir)