Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin 'Go' requires plugin 'org.intellij.intelliLang' to be installed #1056

Open
rli opened this issue Jul 7, 2022 · 4 comments
Open

Plugin 'Go' requires plugin 'org.intellij.intelliLang' to be installed #1056

rli opened this issue Jul 7, 2022 · 4 comments
Labels
Milestone

Comments

@rli
Copy link

rli commented Jul 7, 2022

Describe the bug

    [   1043]   WARN - #c.i.i.p.PluginManager - Problems found loading plugins:
      The Go (id=org.jetbrains.plugins.go, path=/codebuild/output/src408993822/src/github.com/aws/aws-toolkit-jetbrains/jetbrains-ultimate/build/idea-sandbox/plugins-test/go, version=222.3345.16) plugin Plugin 'Go' requires plugin 'org.intellij.intelliLang' to be installed

To Reproduce

IU 222.3345-EAP-CANDIDATE-SNAPSHOT
org.jetbrains.plugins.go:222.3345.16

Expected behavior
Automatically pull in transitive dependency

Environment:

  • macOS
  • Gradle 7.4
  • gradle-intellij-plugin 1.7.0-20220706.013502-36
@hsz
Copy link
Member

hsz commented Jul 8, 2022

With the following setup, I can't reproduce it:

image

platformType = IU
platformVersion = 222-EAP-SNAPSHOT
platformPlugins = org.jetbrains.plugins.go:222.3345.16

@Undin
Copy link
Contributor

Undin commented Jul 8, 2022

@hsz I've faced with this problem as well in EduTools plugin

The essential thing here for reproducing is to run tests where Go plugin should be used. To reproduce, you can use this branch and run tests in Edu-Go module. To ensure that everything works if you add org.intellij.intelliLang dependency manually, just revert the latest commit in the branch

I suppose this bug appeared because recently org.intellij.intelliLang dependency was added via plugin model v2 syntax but previously v1 syntax was used

@hsz
Copy link
Member

hsz commented Jul 8, 2022

Then it sounds familiar to #1048, isn't it?

@rli
Copy link
Author

rli commented Jul 8, 2022

go:212.4746.92 also uses model v2 syntax, but org.intellij.intelliLang is new in 222.3345.16, so that is probably the diff here

I don't think this is quite the same as 1048 since the classes are being resolved correctly, but since the plugin is diabled, the service loader isn't returning anything?

[    755]   WARN - #c.i.i.p.PluginManager - Problems found loading plugins:
  The Go (id=org.jetbrains.plugins.go, path=~/idetools/aws-toolkit-jetbrains/jetbrains-ultimate/build/idea-sandbox/plugins-test/go, version=222.3345.16) plugin Plugin 'Go' requires plugin 'org.intellij.intelliLang' to be installed
java.lang.NullPointerException: Cannot invoke "com.goide.project.GoModuleSettings.setGoSupportEnabled(boolean)" because the return value of "com.goide.project.GoModuleSettings.getInstance(com.intellij.openapi.module.Module)" is nulljava.lang.RuntimeException: java.lang.NullPointerException: Cannot invoke "com.goide.project.GoModuleSettings.setGoSupportEnabled(boolean)" because the return value of "com.goide.project.GoModuleSettings.getInstance(com.intellij.openapi.module.Module)" is null
	at com.intellij.openapi.application.impl.LaterInvocator.invokeAndWait(LaterInvocator.java:118)
	at com.intellij.openapi.application.impl.ApplicationImpl.invokeAndWait(ApplicationImpl.java:505)

Will see if I can get more details somehow

@hsz hsz added this to the 2.x milestone Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants