Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A significant speed up of the dipolar kernal
Currently the effective dipolar evolution time vector is interpolated on every run of dipolar kernal even though it never changes. Interpolation should be avoid as much as possible as it is very slow in Python. This interpolation is now cached so it only done once per pathway.
Speedup:
(Using CVXOPT nnlssolver) 9.0s -> 7.9s 10% faster
(Using quadprog nnlssolver) 2.8s -> 2.2s 20 % faster
CProfile (using quadprog):
Before:
After: