Download artifacts in trained-models/, not root

Fixes #5
JasonGross · Jan 19, 2024 · e28e04c · e28e04c
1 parent 7e09009
commit e28e04c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/gbmi/model.py b/gbmi/model.py
@@ -263,14 +263,16 @@ def try_load_model_from_wandb_download(
 
 
 def try_load_model_from_wandb(
-    config: Config, wandb_model_path: str
+    config: Config, wandb_model_path: str, root: Optional[Union[str, Path]] = None
 ) -> Optional[Tuple[RunData, HookedTransformer]]:
     # Try loading the model from wandb
+    if root is None:
+        root = get_trained_model_dir(create=True)
     model_dir = None
     try:
         api = wandb.Api()
         model_at = api.artifact(wandb_model_path)
-        model_dir = Path(model_at.download())
+        model_dir = Path(model_at.download(str(root)))
     except Exception as e:
         logging.warning(f"Could not load model {wandb_model_path} from wandb:\n", e)
     if model_dir is not None:

diff --git a/notebooks_jason/max_of_2_grokking.py b/notebooks_jason/max_of_2_grokking.py
@@ -10,6 +10,8 @@
 import torch
 import wandb
 
+from gbmi.utils import get_trained_model_dir
+
 api = wandb.Api()
 
 # %%
@@ -65,8 +67,9 @@
 # %%
 model_artifacts = list(artifact.logged_by().logged_artifacts())
 # %%
+root = get_trained_model_dir(create=True)
 models = [
-    (a.version, try_load_model_from_wandb_download(cfg, a.download()), a)
+    (a.version, try_load_model_from_wandb_download(cfg, a.download(str(root))), a)
     for a in model_artifacts
     if a.type == "model"
 ]