fix(notice): validate correct keyword #5808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanDeDobbeleer
force-pushed
the
fix-v24
branch
from
65799f7 to
870acdb
Compare
JanDeDobbeleer
force-pushed
the
fix-v24
branch
from
0122497 to
4bd5ade
Compare
heaths
reviewed
Nov 4, 2024
| text, length := e.writeBlockSegments(block) | ||
|
|
||
| // do not print anything when we don't have any text | ||
| if length == 0 { |
There was a problem hiding this comment.
Following the call stack - though maybe I missed something - it seems like whitespace would be significant, right? My second line had leading and trailing whitespace for aesthetics and mouse selection such that the rendered length would always be >= 2. Or was whitespace stripped if it was only whitespace somewhere? If needed, I can move any whitespace into conditionals.
There was a problem hiding this comment.
I tested this and it hides the block correctly. Whitespace segments are treated as empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
resolves #5809