Ignore TFM if not found #4421
Merged
Ignore TFM if not found #4421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomorgado
force-pushed
the
project
branch
4 times, most recently
from
c52de54 to
f0522c8
Compare
paulomorgado
force-pushed
the
project
branch
2 times, most recently
from
9f8a18a to
3e82b5a
Compare
JanDeDobbeleer
force-pushed
the
project
branch
from
3e82b5a to
03f829f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Visual Studio solution and solution filter files do not have a TFM (
Target) and fail because of that.How
Defaulted to an empty string for the
Targetwhen not found.I can add unit tests for this, but I'm no GO programmer and I haven't found any.
If someone points me at a similar feature, I can add the tests.