Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(themes): yarn nerdfont 3.x icon codepoint #4407

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

mateusz-bajorek
Copy link
Contributor

@mateusz-bajorek mateusz-bajorek commented Oct 30, 2023

Prerequisites

  • I have read and understood the contributing guide.
  • The commit message follows the conventional commits guidelines.
  • Tests for the changes have been added (for bug fixes / features).
  • Docs have been added/updated (for bug fixes / features).

Description

🤖 Generated by Copilot at 450512d

This pull request fixes a bug in the Yarn icon display and adds tests and schema updates to ensure consistency. It changes the escape sequence for the Yarn icon from \u to \U in node.go, config_test.go, and themes/schema.json.

How

🤖 Generated by Copilot at 450512d

  • Fix Yarn icon display bug by using \U escape sequence for Unicode code point \U000F011B in node.go (link)
  • Update default value of Yarn icon in themes/schema.json to match the \U escape sequence (link)
  • Add test cases for escaping Unicode code point \U000F011B and glyph 󰄛 in config_test.go (link)

@mateusz-bajorek
Copy link
Contributor Author

Sorry @JanDeDobbeleer, I didn't notice in my previous PR that Go and JSON require different handling for the 5 hexadecimal digits long codepoints.

@JanDeDobbeleer JanDeDobbeleer enabled auto-merge (rebase) October 30, 2023 13:10
@JanDeDobbeleer JanDeDobbeleer merged commit 4b1fbb8 into JanDeDobbeleer:main Oct 30, 2023
14 checks passed
@mateusz-bajorek mateusz-bajorek deleted the fix_yarn branch October 30, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants