Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(os): icon not showing up on almalinux. added 'almalinux' to the icon map #4349

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

BPplays
Copy link

@BPplays BPplays commented Oct 16, 2023

Prerequisites

  • I have read and understood the [contributing guide][CONTRIBUTING.md].
  • The commit message follows the [conventional commits][cc] guidelines.
  • [] Tests for the changes have been added (for bug fixes / features).
  • [] Docs have been added/updated (for bug fixes / features).

Description

on almalinux 9.2 (Turquoise Kodkod) icons don't seem to be working.
it seems that its detected as 'almalinux' instead of 'almalinux9' or 'alma'

how

adding 'almalinux' to the icon map seems to fix it

@BPplays BPplays mentioned this pull request Oct 16, 2023
1 task
@BPplays BPplays changed the title fixed icon not showing up on almalinux by adding 'almalinux' to the icon map fix(os): icon not showing up on almalinux. added 'almalinux' to the icon map Oct 17, 2023
@JanDeDobbeleer JanDeDobbeleer enabled auto-merge (rebase) October 17, 2023 06:29
@JanDeDobbeleer JanDeDobbeleer merged commit dadbb28 into JanDeDobbeleer:main Oct 17, 2023
9 checks passed
@JanDeDobbeleer
Copy link
Owner

@all-contributors please add @BPplays for code

This is pure magic 🪄! @holopin-bot @BPplays wizard

@holopin-bot
Copy link

holopin-bot bot commented Oct 17, 2023

Congratulations @BPplays, you just earned a badge! Here it is: https://holopin.io/claim/clntyaqon133950fld6rj514kg

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@allcontributors
Copy link
Contributor

@JanDeDobbeleer

I've put up a pull request to add @BPplays! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants