Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove io/ioutil #4337

Merged
merged 1 commit into from
Oct 14, 2023
Merged

Conversation

ginglis13
Copy link
Contributor

Prerequisites

  • I have read and understood the contributing guide.
  • The commit message follows the conventional commits guidelines.
  • [n/a] Tests for the changes have been added (for bug fixes / features).
  • [n/a] Docs have been added/updated (for bug fixes / features).

Description

io/ioutil has been deprected since go 1.16
https://pkg.go.dev/io/ioutil

How

@JanDeDobbeleer
Copy link
Owner

please change the commit message to refactor: remove io/ioutil

@ginglis13 ginglis13 changed the title deps: remove io/ioutil refactor: remove io/ioutil Oct 13, 2023
@ginglis13
Copy link
Contributor Author

@JanDeDobbeleer done PTAL

io/ioutil has been deprected since go 1.16
https://pkg.go.dev/io/ioutil

Signed-off-by: ginglis13 <ginglis05@gmail.com>
@JanDeDobbeleer JanDeDobbeleer enabled auto-merge (rebase) October 14, 2023 17:24
@JanDeDobbeleer JanDeDobbeleer merged commit eef39ef into JanDeDobbeleer:main Oct 14, 2023
@JanDeDobbeleer
Copy link
Owner

@all-contributors please add @ginglis13 for code

This is pure magic 🪄! @holopin-bot @ginglis13 wizard

@holopin-bot
Copy link

holopin-bot bot commented Oct 14, 2023

Congratulations @ginglis13, you just earned a badge! Here it is: https://holopin.io/claim/clnqbduvp01480fmm1d0tj10d

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@allcontributors
Copy link
Contributor

@JanDeDobbeleer

I've put up a pull request to add @ginglis13! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants