feat(shell): add case insensitivity to filecontent method #4306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JanDeDobbeleer let me know your thoughts & what you want me to tidyup |
|
Closing due to comment in main PR, keeping this for reference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
🤖 Generated by Copilot at 66fa77c
Fix file content reading bug in
FileContentfunction. Improve shell segment compatibility with different file systems and platforms.How
🤖 Generated by Copilot at 66fa77c
FileContentfunction (link)FileContentfunction (link)shell_test.goto use lower case file names for testingFileContentfunction (link)