Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit one error (CPU IS NOT MEMORY) #4248

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Edit one error (CPU IS NOT MEMORY) #4248

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
accf37d
fix: Rename "CPU" to "MEM" for 1_shell theme because it shows MEM stats
oriionn Sep 10, 2023
e27eb77
Merge branch 'main' into main
oriionn Sep 12, 2023
79d92d4
fix: Globalize GB view with percentage.
oriionn Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion themes/1_shell.omp.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
{
"foreground": "#94ffa2",
"style": "diamond",
"template": " <#ffffff>CPU:</> {{ round .PhysicalPercentUsed .Precision }}% ",
"template": " <#ffffff>MEM:</> {{ round .PhysicalPercentUsed .Precision }}% ",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would then also need to remove the segment below as it indicates the same.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not specify exactly the same thing: the segment below specifies the number of GB available, whereas the percentage specifies the percentage available.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oriionn I would add that to the same segment in that case as this will fetch the information twice, slowing things down unnecessarily. If that’s not possible, use a text segment and cross segment properties.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And that's it! I've put together the number of GBs and the percentage into one

"type": "sysinfo"
},
{
Expand Down