Library refactor #28
Open
Library refactor #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces redundant code. Also replace many state and binding properties with simple properties
|
This has some major changes in it that I made unprompted, so feel free to make further adjustments if it's something you'd want to move forward with. The readme would also need to be rewritten which I could help with if you wanted. |
|
Thank you for all of your work on this! This is all looking great so far. It will probably take me some time to go through all of the changes and everything before merging. |
|
I just realized ImageDetailsRemote could be moved to a file in the remote target so it isn't included in the regular image viewer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls the different parts of the app out into their own files to reduce redundancy and to make it easier to add features in the future.
ImageViewerno longer depends onURLImageas it did not use it.ImageViewerRemotenow depends onImageViewerto reduce redundant code.The image viewers now take details objects (
ImageDetailsandImageDetailsRemote) to load images. This is to make it easier to implement a gallery mode in the future where each image can have its own unique caption and aspect ratio.Many properties that were previously Binding or State properties were changed to be standard properties as there was no functional benefit to having their property wrapper.
These changes change the code interface and thus this pull request is not compatible with 2.0, so it would need to be made into a new major version.