Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address comments made in this PR: jonhoo/flurry#109
Key points:
Some notes: I did look at using the thread_id but this is a nightly only API so I'll leave it out for now as we're fully working on stable
I'm seeing some suspiciously good benchmark results:
However it looked like we were actually being bottlenecked by the allocation time, when I increase the iter count in the benchmark we can see great scaling: at 16 core we're seeing a near 60x improvment over regular atomic numbers