improve: speed up addin loading with webpack code splitting #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohit038
added
the
status: needs review
tobiasdiez
reviewed
Apr 24, 2023
| maxInitialRequests: 30, | ||
| automaticNameDelimiter: '~', | ||
| enforceSizeThreshold: 50000, | ||
| cacheGroups: { |
There was a problem hiding this comment.
Most of these seem to be the default values. I think its more maintainable if only non-default values are specified, or is it necessary to specify everything?
| splitChunks: { | ||
| chunks: 'all', | ||
| minSize: 20000, | ||
| maxSize: 50000, |
There was a problem hiding this comment.
I'm a bit unsure about the maxSize. The taskpane is now split in over 100 chunks. While this is more performant during local development, I suspect this actually performs worse if you add real latency when deployed to a server. However, I'm not sure how to test it at the moment. Should we wait until I've fixed the deployment to azure (hopefully in the next few days)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR configures the optimization.splitChunks option of webpack to split the code into smaller chunks that can be loaded on demand or in parallel. This reduces the bundle size and the initial loading time of the addin. Previously,
yarn starttook a long time to load. After this PR, the addin will load in considerably less time.