Add readme #1
Add readme #1
Conversation
|
@znichollscr can you take a look |
…E, DataLad sibling description, merge instructions.
Co-authored-by: znichollscr <114576287+znichollscr@users.noreply.github.com>
Co-authored-by: znichollscr <114576287+znichollscr@users.noreply.github.com>
Co-authored-by: znichollscr <114576287+znichollscr@users.noreply.github.com>
Co-authored-by: znichollscr <114576287+znichollscr@users.noreply.github.com>
Co-authored-by: znichollscr <114576287+znichollscr@users.noreply.github.com>
Co-authored-by: znichollscr <114576287+znichollscr@users.noreply.github.com>
Co-authored-by: znichollscr <114576287+znichollscr@users.noreply.github.com>
Co-authored-by: znichollscr <114576287+znichollscr@users.noreply.github.com>
Co-authored-by: znichollscr <114576287+znichollscr@users.noreply.github.com>
Co-authored-by: Johannes Gütschow <mail@johannes-guetschow.de>
Co-authored-by: Johannes Gütschow <mail@johannes-guetschow.de>
Co-authored-by: Johannes Gütschow <mail@johannes-guetschow.de>
Co-authored-by: Johannes Gütschow <mail@johannes-guetschow.de>
Co-authored-by: Johannes Gütschow <mail@johannes-guetschow.de>
Co-authored-by: znichollscr <114576287+znichollscr@users.noreply.github.com>
|
@JGuetschow @znichollscr thanks for the suggestions. I went through the Readme again and made some small changes. Can you take a look? |
There was a problem hiding this comment.
Nice work. There are way more comments and nits than normal because I'm being nit picky because we'll likely re-use this or something like it. Having lots of comments is good practice for you to get used to MRs and reviews, but don't worry you'll probably never have one like this again. (For reference, in future for something like this I would probably just make a MR into your branch to save you clicking so much, but as I said good practice here.)
Nice job. Over to you to accept changes, make other changes, discuss in threads etc. then assign the MR to Johannes for final review and merging.
=== Do not change lines below ===
{
"chain": [],
"cmd": "./venv/bin/python3 src/read_version.py --version v230913",
"dsid": "24f90b12-e4a9-4e2c-995d-a54ed4cd49c7",
"exit": 0,
"extra_inputs": [],
"inputs": [
"downloaded_data/v230913/0. GCP-CEM.csv"
],
"outputs": [
"extracted_data/v230913/Robbie_Andrew_Cement_Production_CO2_230913.nc",
"extracted_data/v230913/Robbie_Andrew_Cement_Production_CO2_230913.yaml",
"extracted_data/v230913/Robbie_Andrew_Cement_Production_CO2_230913.csv"
],
"pwd": "."
}
^^^ Do not change lines above ^^^
=== Do not change lines below ===
{
"chain": [],
"cmd": "./venv/bin/python3 src/read_version.py --version v230428",
"dsid": "24f90b12-e4a9-4e2c-995d-a54ed4cd49c7",
"exit": 0,
"extra_inputs": [],
"inputs": [
"downloaded_data/v230428/1. Cement_emissions_data.csv"
],
"outputs": [
"extracted_data/v230428/Robbie_Andrew_Cement_Production_CO2_230428.nc",
"extracted_data/v230428/Robbie_Andrew_Cement_Production_CO2_230428.yaml",
"extracted_data/v230428/Robbie_Andrew_Cement_Production_CO2_230428.csv"
],
"pwd": "."
}
^^^ Do not change lines above ^^^
Co-authored-by: znichollscr <114576287+znichollscr@users.noreply.github.com>
|
Hi, thank you for your comments. I did the changes in the Readme. I hope I caught all the comments. Let me know if I should change anything else. @znichollscr |
|
All looks good to me. We've made a bit of a mess here, so I would suggest we do a very simple, clean commit on Gin. I'll ping you on slack |
No description provided.