This repository has been archived by the owner on Nov 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 753
feat: Add "Total Remaining Budget" display #3368
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added display for "Total Remaining Budget" beneath budget information. Calculated remaining budget for categorized and multi-categorized budgets. Included multi-language support for the "Total Remaining Budget" text. Enhanced user experience by providing a clear overview of remaining budget without manual summarization.
ILIYANGERMANOV
suggested changes
Jul 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, a few changes:
- use
String?
for the UI state of the new text - do the calculation and formatting in the VM
This is needed for performance and architecture reasons.
screen/budgets/src/main/java/com/ivy/budgets/BudgetViewModel.kt
Outdated
Show resolved
Hide resolved
screen/budgets/src/main/java/com/ivy/budgets/BudgetViewModel.kt
Outdated
Show resolved
Hide resolved
Ping me for re-review when you've applied the changes |
@ILIYANGERMANOV applied the changes. please re-review it |
ILIYANGERMANOV
suggested changes
Jul 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unnecessary state, fix Detekt and we can merge
screen/budgets/src/main/java/com/ivy/budgets/BudgetViewModel.kt
Outdated
Show resolved
Hide resolved
screen/budgets/src/main/java/com/ivy/budgets/BudgetViewModel.kt
Outdated
Show resolved
Hide resolved
its ready to merge |
ILIYANGERMANOV
approved these changes
Jul 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request (PR) checklist
Please check if your pull request fulfills the following requirements:
Screen recording of interacting with your changes:
WhatsApp.Video.2024-07-25.at.18.39.48_d1b07eed.mp4
What's changed?
Does this PR close any GitHub issues? (do not delete)