Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #320 and #321 :The Service card content fit well now; navigation bar position changes fixed #322

Closed
wants to merge 0 commits into from

Conversation

debangi29
Copy link
Contributor

Fixed issue #320 and #321

1. Service card fit well inside the box

Now:

image

Old

Screenshot 2024-05-19 160617

2. Navigation bar positioning changes fixed now:

New

image

Old:

image

Copy link

vercel bot commented May 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
community-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2024 11:18am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @debangi29! 🎉 , Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project. Our team will review your changes shortly.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented May 19, 2024

Deploy Preview for opensourcevillage ready!

Name Link
🔨 Latest commit 29d087b
🔍 Latest deploy log https://app.netlify.com/sites/opensourcevillage/deploys/664a04f01da23b0008427614
😎 Deploy Preview https://deploy-preview-322--opensourcevillage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@debangi29
Copy link
Contributor Author

Some of the new PRs removes the old changes made... Please check
FAQs in nav bar was removed; I have again introduced it in this pull request.

Thankss @Its-Aman-Yadav

@debangi29 debangi29 changed the title The Service card content fit well now; navigation bar position changes fixed Fixed issue #320 and #321 :The Service card content fit well now; navigation bar position changes fixed May 19, 2024
@Its-Aman-Yadav
Copy link
Owner

Thank you @debangi29 for the changes, and yeah please make a new branch for every future PR so that merge conflicts will be less

Thank you again

@debangi29
Copy link
Contributor Author

I have made a pull request to revert-10-main; It shows able to merge; Is it okay? @Its-Aman-Yadav

Its-Aman-Yadav added a commit that referenced this pull request May 19, 2024
Fixed issue #320 and #321 :The Service card content fit well now; navigation bar position changes fixed #322
@debangi29 debangi29 closed this May 19, 2024
Its-Aman-Yadav added a commit that referenced this pull request May 20, 2024
…now; navigation bar position changes fixed #322"
Its-Aman-Yadav added a commit that referenced this pull request May 20, 2024
Revert "Fixed issue #320 and #321 :The Service card content fit well now; navigation bar position changes fixed #322"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants