Fixes #987 #988
Fixes #987 #988
Conversation
|
@mahmoudbahaa Unfortunately, this change is not working for me. @IsmaelMartinez can you check once? |
|
@jijojosephk, I dunno when I will have time to look at this. I wonder @mahmoudbahaa if it is because now is not calling the electron backend When we implemented this, ages ago, we had to use the electron call but I don't remember the reasons behind it. |
1) make control and key zooming work with or without shift. 2) added mouse wheel scrolling 3) made a mimum and maximum for setting zoom level
…gistering zooming shortcut handlers
mahmoudbahaa
force-pushed
the
fix-shortcut-handling
branch
from
a7fa9d0 to
ebbf88d
Compare
|
I am going to wait probably until tomorrow to ensure the other pre-release had a bit of time to be tested. Thanks again for your work! |
|
@IsmaelMartinez This had problems I was waiting for @mahmoudbahaa to comeback. |
|
#987 (comment) Harridu did test it and he seem happy. Is a pre-release, if we see people complaining we can revert the changes. (not idea but git is for that).
I will not revert the snap edge release as it is only 900ish people in there... and is edge after all. |
|
By the way, can you be a bit more specific, @jijojosephk ? What didn't work? I might be able to test in the macOS version on Monday |
|
Hi @jijojosephk , I have test it in MacOS and I can confirm it only works in the newer version of teams. The old version doesn't break so I think that is an ok compromise. I will mark it as released and do the next pre-release |
#987