Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Option + Left and Option + Right keyboard shortcut on MacOS #1102

Merged
merged 3 commits into from
Feb 14, 2024

Conversation

jstastny
Copy link
Contributor

@jstastny jstastny commented Feb 13, 2024

Fixes #1101

I first wanted to replace the problematic Option + Left with Command + Left for history navigation, but it did not work for some reason, so I ended up removing the history navigation shortcuts completely for Mac.

The previous attempt to use Command (Meta) + Left / Right did not work.
@jstastny jstastny force-pushed the js/mac-back-navigation branch from 1f53fb1 to efeef6c Compare February 13, 2024 11:06
@jijojosephk
Copy link
Collaborator

@jstastny could you update package.json and com.github.IsmaelMartinez.teams_for_linux.appdata.xml with version details ?

@jstastny
Copy link
Contributor Author

Sure. Done in d6458c0

@jijojosephk
Copy link
Collaborator

Thanks @jstastny

@jijojosephk jijojosephk merged commit f42a196 into IsmaelMartinez:develop Feb 14, 2024
3 checks passed
@jstastny jstastny deleted the js/mac-back-navigation branch February 14, 2024 12:28
@jijojosephk
Copy link
Collaborator

@jstastny you PR causing some issues. Had you tested? or did you miss something while sending the PR?

image

@jstastny
Copy link
Contributor Author

That is weird. I have successfully built the app locally and use it from then on. It works as expected -- the keyboard shortcut Option + Left (and Right) is not handled by the app, but left for the OS.

@jstastny jstastny changed the title Navigation on Mac with Command instead of Option Remove Option + Left and Option + Right keyboard shortcut on MacOS Feb 20, 2024
@jstastny
Copy link
Contributor Author

Thinking more about it, this may have broken all the keyboard shortcuts -- because of missing import.

I am adding the import in a separate PR.

@jijojosephk
Copy link
Collaborator

No worries, probably related to linux environment. It's fixed anyway!

@jstastny
Copy link
Contributor Author

jstastny commented Feb 20, 2024

I can see you fixed it in c5b6295 -- exactly the same way I was about to fix it.

@jijojosephk
Copy link
Collaborator

jijojosephk commented Feb 20, 2024

Yeah, the same. It's ok, done and dusted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mac keyboard shortcut Option (⌥) + Left
2 participants