Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip test if exception SkipTest is raised #1895

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Skip test if exception SkipTest is raised #1895

merged 2 commits into from
Jan 31, 2025

Conversation

BCSharp
Copy link
Member

@BCSharp BCSharp commented Jan 31, 2025

I think this is a better way of handling fcntl_test failure on Windows (#1893). It is skipping by exception name SkipTest rather than unittest.SkipTest because I coudn't figure out how to retrieve the defining module name.

slozier
slozier approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@slozier slozier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! There are probably a few test cases that are excluded just because of this failure that we could "enable".

@BCSharp BCSharp merged commit 578972c into IronLanguages:main Jan 31, 2025
8 checks passed
@BCSharp BCSharp deleted the skiptest branch January 31, 2025 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slozier slozier slozier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BCSharp @slozier