Merge pull request #25 from IoraHealth/ar-fix-bug-with-restful-update…

…-supporting-both-patch-and-put

Fix bug with restful update supporting both patch and put

examples/output/model/v1/calendar-event.js

@@ -16,10 +16,6 @@ export default DS.Model.extend({
   show: function() {
     throw new Error("'show' is not supported by the api");
   }
-,
-  update: function() {
-    throw new Error("'update' is not supported by the api");
-  }
 ,
   delete: function() {
     throw new Error("'delete' is not supported by the api");

examples/output/model/v20150918/emergency-contact.js

@@ -15,10 +15,6 @@ export default DS.Model.extend({
   update: function() {
     throw new Error("'update' is not supported by the api");
   }
-,
-  update: function() {
-    throw new Error("'update' is not supported by the api");
-  }
 ,
   delete: function() {
     throw new Error("'delete' is not supported by the api");

examples/output/model/v20150918/location.js

@@ -18,10 +18,6 @@ export default DS.Model.extend({
   update: function() {
     throw new Error("'update' is not supported by the api");
   }
-,
-  update: function() {
-    throw new Error("'update' is not supported by the api");
-  }
 ,
   delete: function() {
     throw new Error("'delete' is not supported by the api");

examples/output/model/v20150918/patient.js

@@ -22,10 +22,6 @@ export default DS.Model.extend({
   update: function() {
     throw new Error("'update' is not supported by the api");
   }
-,
-  update: function() {
-    throw new Error("'update' is not supported by the api");
-  }
 ,
   delete: function() {
     throw new Error("'delete' is not supported by the api");

examples/output/model/v20150918/practice.js

@@ -17,10 +17,6 @@ export default DS.Model.extend({
   update: function() {
     throw new Error("'update' is not supported by the api");
   }
-,
-  update: function() {
-    throw new Error("'update' is not supported by the api");
-  }
 ,
   delete: function() {
     throw new Error("'delete' is not supported by the api");

examples/output/model/v20150918/staff-member.js

@@ -19,10 +19,6 @@ export default DS.Model.extend({
   update: function() {
     throw new Error("'update' is not supported by the api");
   }
-,
-  update: function() {
-    throw new Error("'update' is not supported by the api");
-  }
 ,
   delete: function() {
     throw new Error("'delete' is not supported by the api");

examples/output/model/v20150918/state-of-health.js

@@ -12,10 +12,6 @@ export default DS.Model.extend({
   update: function() {
     throw new Error("'update' is not supported by the api");
   }
-,
-  update: function() {
-    throw new Error("'update' is not supported by the api");
-  }
 ,
   delete: function() {
     throw new Error("'delete' is not supported by the api");

examples/output/model/v3/medication-verification.js

@@ -14,10 +14,6 @@ export default DS.Model.extend({
   update: function() {
     throw new Error("'update' is not supported by the api");
   }
-,
-  update: function() {
-    throw new Error("'update' is not supported by the api");
-  }
 ,
   delete: function() {
     throw new Error("'delete' is not supported by the api");

examples/output/model/v3/patient.js

@@ -22,10 +22,6 @@ export default DS.Model.extend({
   update: function() {
     throw new Error("'update' is not supported by the api");
   }
-,
-  update: function() {
-    throw new Error("'update' is not supported by the api");
-  }
 ,
   delete: function() {
     throw new Error("'delete' is not supported by the api");

lib/braise/link_action.ex

@@ -26,7 +26,6 @@ defmodule Braise.LinkAction do
       %Braise.LinkAction{restful: true, name: :show, method: "GET", on_member: true},
       %Braise.LinkAction{restful: true, name: :create, method: "POST", on_member: false},
       %Braise.LinkAction{restful: true, name: :update, method: "PUT", on_member: true},
-      %Braise.LinkAction{restful: true, name: :update, method: "PATCH", on_member: true},
       %Braise.LinkAction{restful: true, name: :delete, method: "DELETE", on_member: true}
     ]
 
@@ -50,7 +49,7 @@ defmodule Braise.LinkAction do
     %Braise.LinkAction{restful: true, name: :update, method: "PUT", on_member: true}
   end
   defp restful_action("PATCH", _) do
-    %Braise.LinkAction{restful: true, name: :update, method: "PATCH", on_member: true}
+    %Braise.LinkAction{restful: true, name: :update, method: "PUT", on_member: true}
   end
   defp restful_action("DELETE", _) do
     %Braise.LinkAction{restful: true, name: :delete, method: "DELETE", on_member: true}

test/link_action_test.exs

@@ -23,9 +23,9 @@ defmodule LinkActionTest do
     assert name("patient", link) == %Braise.LinkAction{method: "PUT", name: :update, on_member: true, restful: true}
   end
 
-  test "restful update action (patch)" do
+  test "restful update action (patch - we group with PUT update action to avoid dups)" do
     link = %{"method"=>"PATCH", "href"=>"http://blah.com/api/v1/patients/123"}
-    assert name("patient", link) == %Braise.LinkAction{method: "PATCH", name: :update, on_member: true, restful: true}
+    assert name("patient", link) == %Braise.LinkAction{method: "PUT", name: :update, on_member: true, restful: true}
   end
 
   test "restful delete action" do
@@ -47,14 +47,13 @@ defmodule LinkActionTest do
 
   test "finding the unsupported-restful actions" do
     index = %Braise.LinkAction{method: "GET", name: :index, on_member: false, restful: true}
+    update = %Braise.LinkAction{method: "PUT", name: :update, on_member: true, restful: true}
     cancel = %Braise.LinkAction{method: "PUT", name: "cancel", on_member: true, restful: false}
-    actions = [index, cancel]
+    actions = [index, update, cancel]
 
     expected = [
       %Braise.LinkAction{method: "GET", name: :show, on_member: true, restful: true},
       %Braise.LinkAction{method: "POST", name: :create, on_member: false, restful: true},
-      %Braise.LinkAction{method: "PUT", name: :update, on_member: true, restful: true},
-      %Braise.LinkAction{method: "PATCH", name: :update, on_member: true, restful: true},
       %Braise.LinkAction{method: "DELETE", name: :delete, on_member: true, restful: true}
     ]
     assert unsupported_restful_actions(actions) == expected