Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for io-classes-1.4 and friends #463

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Update for io-classes-1.4 and friends #463

merged 3 commits into from
Apr 9, 2024

Conversation

amesgen
Copy link
Member

@amesgen amesgen commented Feb 22, 2024 •
edited
Loading

Mirroring IntersectMBO/cardano-haskell-packages#672

Code changes are due to the deprecation of withLiftST; now, MonadST provides a generic stToIO.

@amesgen amesgen requested a review from jorisdral February 22, 2024 11:35
lehins
lehins approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lehins lehins enabled auto-merge February 22, 2024 11:41
@amesgen amesgen disabled auto-merge February 22, 2024 11:42
@amesgen
Copy link
Member Author

amesgen commented Feb 22, 2024 •
edited
Loading

This actually also requires changes in cardano-crypto-class due to changes in io-classes-1.4, will look at this later.

@amesgen amesgen marked this pull request as draft February 22, 2024 11:44
@amesgen amesgen changed the title strict-checked-vars: allow io-classes-1.4 and friends Update for io-classes-1.4 and friends Feb 22, 2024
@amesgen amesgen marked this pull request as ready for review February 22, 2024 13:01
lehins
lehins approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amesgen Looks great thank you.

cardano-crypto-class does need to be released due to this change, since the version on CHaPs does not use io-classes

jorisdral
jorisdral approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@jorisdral jorisdral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

lehins
lehins approved these changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lehins
Copy link
Collaborator

lehins commented Apr 8, 2024

If this PR is ready to be merged, then we just need a rebase on master and a merge

@amesgen amesgen force-pushed the amesgen/relax-io-sim branch from 2fbbc7c to 5b406a0 Compare April 9, 2024 09:18
@amesgen amesgen enabled auto-merge April 9, 2024 09:20
@amesgen amesgen merged commit 681bd98 into master Apr 9, 2024
21 checks passed
@amesgen amesgen deleted the amesgen/relax-io-sim branch April 9, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehins lehins lehins approved these changes

@jorisdral jorisdral jorisdral approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amesgen @lehins @jorisdral