Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KES Agent prerequisites #317

Closed
wants to merge 9 commits into from
Closed

KES Agent prerequisites #317

wants to merge 9 commits into from

Conversation

tdammers
Copy link
Contributor

@tdammers tdammers commented Oct 13, 2022 •
edited
Loading

Adds:

  • Direct serialization/deserialization of KES sign keys: we need this in order to send keys over network sockets without touching the GHC heap (which would violate mlocking protections).
  • Cryptographic RNG: a wrapper around randombytes_buf() from libsodium, to be used for generating mlocked seeds, such that we can generate KES sign keys entirely in mlocked memory.

@tdammers tdammers force-pushed the tdammers/kes-agent-requirements branch 3 times, most recently from ab56c4a to 6a6d0e6 Compare October 18, 2022 10:29
@iquerejeta iquerejeta mentioned this pull request Oct 19, 2022
Closed
@tdammers tdammers force-pushed the tdammers/kes-agent-requirements branch 3 times, most recently from cadc872 to 0fed3d2 Compare October 24, 2022 09:12
@tdammers tdammers force-pushed the tdammers/kes-agent-requirements branch from 0fed3d2 to e275191 Compare November 1, 2022 09:26
@iquerejeta iquerejeta mentioned this pull request Nov 30, 2023
Open
@tdammers tdammers force-pushed the tdammers/kes-agent-requirements branch 3 times, most recently from bbebbe5 to 5d7b000 Compare November 15, 2022 09:38
@tdammers tdammers force-pushed the tdammers/kes-agent-requirements branch 3 times, most recently from 0fb4e86 to 726800d Compare November 28, 2022 12:19
@tdammers tdammers force-pushed the tdammers/kes-agent-requirements branch 5 times, most recently from 5b2d187 to 3541a2c Compare December 6, 2022 08:59
@tdammers tdammers force-pushed the tdammers/kes-agent-requirements branch 2 times, most recently from 6fb2c5e to df02d73 Compare December 13, 2022 20:34
@tdammers tdammers force-pushed the tdammers/kes-agent-requirements branch 2 times, most recently from 36f4a3b to 0cac5ae Compare December 22, 2022 09:38
@tdammers tdammers force-pushed the tdammers/kes-agent-requirements branch 2 times, most recently from 7ea7446 to 31507b0 Compare January 12, 2023 08:52
@tdammers tdammers force-pushed the tdammers/kes-agent-requirements branch 2 times, most recently from 4c0f13b to b5ec12e Compare January 24, 2023 08:33
@tdammers tdammers force-pushed the tdammers/kes-agent-requirements branch 2 times, most recently from 106de1e to 6bea65f Compare January 31, 2023 10:06
@tdammers
Copy link
Contributor Author

tdammers commented Apr 19, 2023 •
edited
Loading

This currently depends on #388 #411 and #389; those should be dealt with first before merging this.

@tdammers tdammers force-pushed the tdammers/kes-agent-requirements branch from 3e96454 to 1b3fcb4 Compare May 24, 2023 12:32
@tdammers tdammers force-pushed the tdammers/kes-agent-requirements branch 2 times, most recently from 985cc6b to 20b6bde Compare June 21, 2023 07:35
@tdammers tdammers force-pushed the tdammers/kes-agent-requirements branch 2 times, most recently from e6578d7 to 70d4fa9 Compare June 22, 2023 14:28
@tdammers tdammers force-pushed the tdammers/kes-agent-requirements branch 2 times, most recently from 71974b9 to 8a1f1ce Compare August 24, 2023 07:53
@tdammers tdammers marked this pull request as ready for review August 24, 2023 07:55
@tdammers tdammers requested a review from lehins August 24, 2023 07:56
@tdammers tdammers force-pushed the tdammers/kes-agent-requirements branch from 4df99b4 to 512b576 Compare October 30, 2023 17:16
lehins
lehins requested changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll review more tomorrow. Here is my feedback thus far

cardano-crypto-class/src/Cardano/Crypto/DirectSerialise.hs Outdated Show resolved Hide resolved
cardano-crypto-class/src/Cardano/Crypto/DirectSerialise.hs Outdated Show resolved Hide resolved
cardano-crypto-class/src/Cardano/Crypto/Libsodium/Memory/Internal.hs Outdated Show resolved Hide resolved
cardano-crypto-class/src/Cardano/Crypto/KES/CompactSum.hs Show resolved Hide resolved
cardano-crypto-class/src/Cardano/Crypto/KES/CompactSum.hs Outdated Show resolved Hide resolved
@tdammers tdammers force-pushed the tdammers/kes-agent-requirements branch from 798e4d9 to d893f9c Compare November 1, 2023 10:24
@tdammers tdammers force-pushed the tdammers/kes-agent-requirements branch from 11143c7 to 6244ddc Compare November 9, 2023 12:07
@tdammers tdammers force-pushed the tdammers/kes-agent-requirements branch from 6244ddc to a176c15 Compare March 8, 2024 11:17
@tdammers tdammers requested a review from lehins March 8, 2024 11:18
@tdammers tdammers force-pushed the tdammers/kes-agent-requirements branch from a176c15 to c1680ae Compare April 29, 2024 14:12
@lehins lehins mentioned this pull request Oct 17, 2024
Merged
6 tasks
@lehins
Copy link
Collaborator

lehins commented Oct 26, 2024

Closing in favor of #504

@lehins lehins closed this Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehins lehins Awaiting requested review from lehins lehins is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdammers @lehins