Skip to content

Remove DIRECTORYNAMEP check in EDITCALLERS #2123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rmkaplan
Copy link
Contributor

So that (EDITCALLERS 'xxx 'UNICODE) works.

UNICODE is both a directory and a file. The DIRECTORYNAMEP test in EDITCALLERS means that nothing happens if called as above. (It would work 'UNCODE. instead of 'UNICODE).

As near as I can tell, nothing breaks if that test is removed--the file is found and the directory doesn't seem to show up.

So that (EDITCALLERS 'xxx 'UNICODE) works
@masinter
Copy link
Member

I don't understand; is it legal to have a file and a directory with the same name?
in Unix? In Meley {DSK}?

@rmkaplan
Copy link
Contributor Author

rmkaplan commented Apr 25, 2025 via email

Copy link
Member

@masinter masinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nut sure why the DIRECTORYNAMEP was added but it doesn't seem to be needed.

The example for this was UNICODE: EDITCALLERS(FOO UNICODE) at MedleyDIR returns without searching while EDITCALLERS(FOO UNICODE.) searches library/UNICODE.

@masinter masinter merged commit 40e3edc into master Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants