Fix docstring for group barrier and add todo for group barrier overload #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diptorupd
approved these changes
Feb 16, 2024
github-actions bot
added a commit
that referenced
this pull request
Feb 16, 2024
Fix docstring for group barrier and add todo for group barrier overload c6cfe7b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the group_barrier function accepts a reference to a group as argument, updated docstring to remove reference to sub_group_barrier.
Also added a TODO to group_barrier implementation that should be done once sub-group feature is added. Also created an issue for it - #1343.