Replace READ_ELEMENT_IF with variadic template, move functions into unnamed namespace #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The functions `tensorstoreToITKComponentType` and `itkToTensorstoreComponentType` are only used internally in their cxx file. Following C++ Core Guidelines, May 11, 2024, "Use an unnamed (anonymous) namespace for all internal/non-exported entities", http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#sf22-use-an-unnamed-anonymous-namespace-for-all-internalnon-exported-entities
N-Dekker
force-pushed
the
ReadFromStore-variadic-template
branch
from
3c57d75 to
4a90bbc
Compare
N-Dekker
changed the title
N-Dekker
commented
Aug 16, 2024
This line of code can just be removed, as was confirmed by Tom Birdsong at InsightSoftwareConsortium#67 (comment)
Replaced the original `READ_ELEMENT_IF` macro with a variadic template, using a C++17 fold-expression. Following C++ Core Guidelines, May 11, 2024, "Don’t use macros for program text manipulation", https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Res-macros
N-Dekker
force-pushed
the
ReadFromStore-variadic-template
branch
from
4a90bbc to
77a2f45
Compare
thewtex
approved these changes
Aug 21, 2024
N-Dekker
commented
Aug 21, 2024
| const ImageIORegion & storeIORegion, | ||
| void * buffer) | ||
| { | ||
| return (ReadFromStoreIfTypesMatch<TPixel>(componentType, store, storeIORegion, buffer) || ...); |
There was a problem hiding this comment.
Thanks for merging, Matt! The most interesting part of this commit, IMhO, is the fold expression above here, which expands to something like (in pseudo code):
return Read<int8_t>() || Read<uint8_t>() || ... || Read<float>() || Read<double>();
N-Dekker
added a commit
to N-Dekker/ITKIOOMEZarrNGFF
that referenced
this pull request
Aug 21, 2024
Replaced the original `ELEMENT_WRITE` macro with a variadic template, using a C++17 fold-expression. Follow-up to pull request InsightSoftwareConsortium#67 commit 77a2f45 "STYLE: Replace READ_ELEMENT_IF with TryToReadFromStore variadic template"
N-Dekker
added a commit
to N-Dekker/ITKIOOMEZarrNGFF
that referenced
this pull request
Aug 21, 2024
Replaced the original `ELEMENT_WRITE` macro with a variadic template, using a C++17 fold-expression. Follow-up to pull request InsightSoftwareConsortium#67 commit 77a2f45 "STYLE: Replace READ_ELEMENT_IF with TryToReadFromStore variadic template"
N-Dekker
added a commit
to N-Dekker/ITKIOOMEZarrNGFF
that referenced
this pull request
Aug 22, 2024
Replaced the original `ELEMENT_WRITE` macro with a variadic template, using a C++17 fold-expression. Follow-up to pull request InsightSoftwareConsortium#67 commit 77a2f45 "STYLE: Replace READ_ELEMENT_IF with TryToReadFromStore variadic template"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some style improvements:
READ_ELEMENT_IFmacro with a variadic template,TryToReadFromStore.tensorstoreToITKComponentTypeanditkToTensorstoreComponentTypeinto an unnamed namespace