feat: handle question component css #287
+242
−43
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| import type { LunaticComponentProps } from '@inseefr/lunatic/components/type' | ||
| import { describe, expect, it, vi } from 'vitest' | ||
|
|
||
| import { shouldAutoNext } from './functions' | ||
|
|
||
| describe('Should auto next', () => { | ||
| it('returns false with non-radio and non-checkbox components', () => { | ||
| const components: LunaticComponentProps[] = [ | ||
| { | ||
| componentType: 'Text', | ||
| id: 'a', | ||
| value: 'v', | ||
| handleChanges: vi.fn(), | ||
| missingResponse: { name: 'a_MISSING' }, | ||
| }, | ||
| ] | ||
| const valueChange = [{ name: 'a', value: 'v2' }] | ||
| expect(shouldAutoNext(components, valueChange)).toBeFalsy() | ||
| }) | ||
| it('returns true with radio components', () => { | ||
| const components: LunaticComponentProps[] = [ | ||
| { | ||
| componentType: 'Radio', | ||
| id: 'a', | ||
| value: '', | ||
| options: [], | ||
| handleChanges: vi.fn(), | ||
| response: { name: 'a' }, | ||
| missingResponse: { name: 'a_MISSING' }, | ||
| }, | ||
| ] | ||
| const valueChange = [{ name: 'a', value: 'v2' }] | ||
| expect(shouldAutoNext(components, valueChange)).toBeTruthy() | ||
| }) | ||
| it('returns true with missing value', () => { | ||
| const components: LunaticComponentProps[] = [ | ||
| { | ||
| componentType: 'Radio', | ||
| id: 'a', | ||
| value: '', | ||
| options: [], | ||
| handleChanges: vi.fn(), | ||
| response: { name: 'a' }, | ||
| missingResponse: { name: 'a_MISSING' }, | ||
| }, | ||
| ] | ||
| const valueChange = [{ name: 'a_MISSING', value: 'DK' }] | ||
| expect(shouldAutoNext(components, valueChange)).toBeTruthy() | ||
| }) | ||
| it('returns true with a radio in a question component', () => { | ||
| const components: LunaticComponentProps[] = [ | ||
| { | ||
| componentType: 'Question', | ||
| id: 'q', | ||
| components: [ | ||
| { | ||
| componentType: 'Radio', | ||
| id: 'a', | ||
| value: '', | ||
| options: [], | ||
| handleChanges: vi.fn(), | ||
| response: { name: 'a' }, | ||
| missingResponse: { name: 'a_MISSING' }, | ||
| }, | ||
| ], | ||
| }, | ||
| ] | ||
| const valueChange = [{ name: 'a', value: 'v2' }] | ||
| expect(shouldAutoNext(components, valueChange)).toBeTruthy() | ||
| }) | ||
| }) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you need to increase it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed a marginTop: 1em that was on every .field-container and should have been called only on the first one. It should not change anything except remove a weird top margin in table cells and it's way easier to handle things in Question components since they use more .field-container.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Just we globally lose some space at the top of the "main part" compared with before