Bugfix: include class in cache key to prevent incorrect cached values #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vazaha-nl thanks for the PR i want to do some formatting changes can you please enable the Github "Allow edits from maintainers" Feature? |
|
@geisi this feature is already enabled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a nice and useful library, unfortunately I discovered it does not always cache the correct value in my specific use case.
In this use case I have different user classes all implementing the Authorizable contract, and policy logic that depends on the user class. As the library does not take the class into account, this can lead to caching of incorrect values, if the models have the same key.
See the added test for an example.
The fix I implemented here is to include the user model class name in the cache key, so it works in all cases.