Rework the whole package #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Baptouuuu
commented
Feb 25, 2025
Comment on lines
+118
to
+121
| ->flatMap(static fn($sideEffect) => match ($autoClose) { | ||
| true => $stream->close()->maybe(), | ||
| false => Maybe::just($sideEffect), | ||
| }); |
There was a problem hiding this comment.
It misses the case of closing the file when the writing failed.
| ->write($chunk) | ||
| ->maybe(), | ||
| ), | ||
| ) |
There was a problem hiding this comment.
Maybe add a call to fsync before closing the file ?
| static fn() => throw new FailedToLoadStream, | ||
| ); | ||
|
|
||
| $register(static fn() => $rewind()); |
There was a problem hiding this comment.
It should close the file on partial read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current handling of IO in Innmind packages is split between
innmind/streamandinnmind/socketfor the low level details on how to read/write to streams and sockets, and this package for a higher abstraction on how to handle these streams.Other packages wanting to deal with IO has to keep track of capabilities (from
innmind/stream) to open streams or directly call to classes frominnmind/socketto open sockets. And also keep track of this packageIOinstance to wrap the streams in order to simplify their usage.This exposes a few problems:
innmind/streamandinnmind/socketuse interfaces which limits the possibilities to add new features in minor versionsSolution
WIP