Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PH-4] mlflow2 support #735

Merged
merged 5 commits into from
Feb 23, 2024
Merged

[PH-4] mlflow2 support #735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3ad694b
mlflow2 support
Nov 20, 2023
c2690e1
helm values update
Nov 23, 2023
080d759
passing mlflow ver to console
Nov 23, 2023
eb53086
resolve comment
Nov 28, 2023
e2394a3
Merge branch 'master' into feature-PH-4-mlflow2-support
ctiml Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/mlflow-model-downloader/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM python:3.7.2-slim
FROM python:3.11.6-slim

WORKDIR /apps

Expand Down
3 changes: 1 addition & 2 deletions apps/mlflow-model-downloader/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
mlflow==1.16.0
boto3==1.17
mlflow==2.5.0
2 changes: 2 additions & 0 deletions chart/templates/console/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,8 @@ spec:
- name: ENABLE_NPS_SURVEY
value: "true"
{{- end }}
- name: MLFLOW_VERSION
value: {{ .Values.modelDeployment.mlflowVersion | quote }}
{{- if .Values.console.enableInviteUsers }}
- name: ENABLE_INVITE_USERS
value: "true"
Expand Down
6 changes: 5 additions & 1 deletion chart/templates/controller/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,11 @@ data:
modelStorageInitializer:
{{ toYaml .Values.modelDeployment.modelStorageInitializer | indent 8 }}
mlflowModelStorageInitializer:
{{ toYaml .Values.modelDeployment.mlflowModelStorageInitializer | indent 8 }}
{{- if eq (int .Values.modelDeployment.mlflowVersion) 1 }}
{{ toYaml .Values.modelDeployment.mlflow1ModelStorageInitializer | indent 8 }}
{{- else }}
{{ toYaml .Values.modelDeployment.mlflow2ModelStorageInitializer | indent 8 }}
{{- end }}
{{- end }}
---
apiVersion: v1
Expand Down
8 changes: 7 additions & 1 deletion chart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,6 +808,7 @@ monitoringAgent:
# Model Deployment
modelDeployment:
enabled: true
mlflowVersion: 2
engineContainer:
image:
repository: seldonio/seldon-core-executor
Expand All @@ -818,11 +819,16 @@ modelDeployment:
repository: kfserving/storage-initializer
tag: v0.4.0
pullPolicy: IfNotPresent
mlflowModelStorageInitializer:
mlflow1ModelStorageInitializer:
image:
repository: infuseai/mlflow-model-downloader
tag: v0.1.1
pullPolicy: IfNotPresent
mlflow2ModelStorageInitializer:
image:
repository: infuseai/mlflow-model-downloader
tag: v0.2.0
pullPolicy: IfNotPresent

# Admin Notebook (Deprecated)
adminNotebook:
Expand Down
Loading